* [PATCH] tcg: drop unused tcg_temp_free define
@ 2023-10-15 1:00 Mike Frysinger
2023-10-15 15:59 ` Philippe Mathieu-Daudé
2023-10-15 18:33 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Mike Frysinger @ 2023-10-15 1:00 UTC (permalink / raw)
To: richard.henderson; +Cc: pbonzini, qemu-devel
Use of the API was removed a while back, but the define wasn't.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
include/tcg/tcg-op.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
index 80cfcf8104b6..3ead59e4594d 100644
--- a/include/tcg/tcg-op.h
+++ b/include/tcg/tcg-op.h
@@ -52,7 +52,6 @@ static inline void tcg_gen_insn_start(target_ulong pc, target_ulong a1,
typedef TCGv_i32 TCGv;
#define tcg_temp_new() tcg_temp_new_i32()
#define tcg_global_mem_new tcg_global_mem_new_i32
-#define tcg_temp_free tcg_temp_free_i32
#define tcgv_tl_temp tcgv_i32_temp
#define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i32
#define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i32
@@ -60,7 +59,6 @@ typedef TCGv_i32 TCGv;
typedef TCGv_i64 TCGv;
#define tcg_temp_new() tcg_temp_new_i64()
#define tcg_global_mem_new tcg_global_mem_new_i64
-#define tcg_temp_free tcg_temp_free_i64
#define tcgv_tl_temp tcgv_i64_temp
#define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i64
#define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i64
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg: drop unused tcg_temp_free define
2023-10-15 1:00 [PATCH] tcg: drop unused tcg_temp_free define Mike Frysinger
@ 2023-10-15 15:59 ` Philippe Mathieu-Daudé
2023-10-15 18:33 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-15 15:59 UTC (permalink / raw)
To: Mike Frysinger, richard.henderson; +Cc: pbonzini, qemu-devel
On 15/10/23 03:00, Mike Frysinger wrote:
> Use of the API was removed a while back, but the define wasn't.
The cleanup started in commit 47f7313d81 ("tcg: Create
tcg/tcg-temp-internal.h") and the last use got removed
in d5920b7280 ("tcg: Remove TCGv from tcg_gen_qemu_{ld,st}_*").
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> include/tcg/tcg-op.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
> index 80cfcf8104b6..3ead59e4594d 100644
> --- a/include/tcg/tcg-op.h
> +++ b/include/tcg/tcg-op.h
> @@ -52,7 +52,6 @@ static inline void tcg_gen_insn_start(target_ulong pc, target_ulong a1,
> typedef TCGv_i32 TCGv;
> #define tcg_temp_new() tcg_temp_new_i32()
> #define tcg_global_mem_new tcg_global_mem_new_i32
> -#define tcg_temp_free tcg_temp_free_i32
> #define tcgv_tl_temp tcgv_i32_temp
> #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i32
> #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i32
> @@ -60,7 +59,6 @@ typedef TCGv_i32 TCGv;
> typedef TCGv_i64 TCGv;
> #define tcg_temp_new() tcg_temp_new_i64()
> #define tcg_global_mem_new tcg_global_mem_new_i64
> -#define tcg_temp_free tcg_temp_free_i64
> #define tcgv_tl_temp tcgv_i64_temp
> #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i64
> #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i64
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg: drop unused tcg_temp_free define
2023-10-15 1:00 [PATCH] tcg: drop unused tcg_temp_free define Mike Frysinger
2023-10-15 15:59 ` Philippe Mathieu-Daudé
@ 2023-10-15 18:33 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2023-10-15 18:33 UTC (permalink / raw)
To: Mike Frysinger; +Cc: pbonzini, qemu-devel
On 10/14/23 18:00, Mike Frysinger wrote:
> Use of the API was removed a while back, but the define wasn't.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> include/tcg/tcg-op.h | 2 --
> 1 file changed, 2 deletions(-)
Thanks for the catch.
Queued.
r~
>
> diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
> index 80cfcf8104b6..3ead59e4594d 100644
> --- a/include/tcg/tcg-op.h
> +++ b/include/tcg/tcg-op.h
> @@ -52,7 +52,6 @@ static inline void tcg_gen_insn_start(target_ulong pc, target_ulong a1,
> typedef TCGv_i32 TCGv;
> #define tcg_temp_new() tcg_temp_new_i32()
> #define tcg_global_mem_new tcg_global_mem_new_i32
> -#define tcg_temp_free tcg_temp_free_i32
> #define tcgv_tl_temp tcgv_i32_temp
> #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i32
> #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i32
> @@ -60,7 +59,6 @@ typedef TCGv_i32 TCGv;
> typedef TCGv_i64 TCGv;
> #define tcg_temp_new() tcg_temp_new_i64()
> #define tcg_global_mem_new tcg_global_mem_new_i64
> -#define tcg_temp_free tcg_temp_free_i64
> #define tcgv_tl_temp tcgv_i64_temp
> #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i64
> #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i64
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-15 18:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-15 1:00 [PATCH] tcg: drop unused tcg_temp_free define Mike Frysinger
2023-10-15 15:59 ` Philippe Mathieu-Daudé
2023-10-15 18:33 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).