From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 09/20] mirror: Update signature of mirror_clip_sectors()
Date: Mon, 5 Jun 2017 18:23:17 -0400 [thread overview]
Message-ID: <820d73f3-7b3f-83f2-d418-cdec96e665d8@redhat.com> (raw)
In-Reply-To: <20170511022036.32225-10-eblake@redhat.com>
On 05/10/2017 10:20 PM, Eric Blake wrote:
> Rather than having a void function that modifies its input
> in-place as the output, change the signature to reduce a layer
> of indirection and return the result.
>
> Suggested-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> v2: new patch
> ---
> block/mirror.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
next prev parent reply other threads:[~2017-06-05 22:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 2:20 [Qemu-devel] [PATCH v2 00/20] make bdrv_is_allocated[_above] byte-based Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 01/20] blockjob: Track job ratelimits via bytes, not sectors Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 02/20] trace: Show blockjob actions " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 03/20] stream: Switch stream_populate() to byte-based Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 04/20] stream: Switch stream_run() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 05/20] commit: Switch commit_populate() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 06/20] commit: Switch commit_run() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 07/20] mirror: Switch MirrorBlockJob " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 08/20] mirror: Switch mirror_do_zero_or_discard() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 09/20] mirror: Update signature of mirror_clip_sectors() Eric Blake
2017-06-05 22:23 ` John Snow [this message]
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 10/20] mirror: Switch mirror_cow_align() to byte-based Eric Blake
2017-06-05 22:24 ` John Snow
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 11/20] mirror: Switch mirror_do_read() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 12/20] mirror: Switch mirror_iteration() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 13/20] block: Drop unused bdrv_round_sectors_to_clusters() Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 14/20] backup: Switch BackupBlockJob to byte-based Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 15/20] backup: Switch block_backup.h " Eric Blake
2017-06-05 22:42 ` John Snow
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 16/20] backup: Switch backup_do_cow() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 17/20] backup: Switch backup_run() " Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 18/20] block: Make bdrv_is_allocated() byte-based Eric Blake
2017-06-05 22:57 ` John Snow
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 19/20] block: Minimize raw use of bds->total_sectors Eric Blake
2017-05-11 2:20 ` [Qemu-devel] [PATCH v2 20/20] block: Make bdrv_is_allocated_above() byte-based Eric Blake
2017-06-05 23:22 ` John Snow
2017-06-05 23:30 ` John Snow
2017-06-05 19:39 ` [Qemu-devel] [PATCH v2 00/20] make bdrv_is_allocated[_above] byte-based Eric Blake
2017-06-05 19:41 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=820d73f3-7b3f-83f2-d418-cdec96e665d8@redhat.com \
--to=jsnow@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).