From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dI0PI-0008RC-OW for qemu-devel@nongnu.org; Mon, 05 Jun 2017 18:23:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dI0PI-0007Kb-1G for qemu-devel@nongnu.org; Mon, 05 Jun 2017 18:23:28 -0400 References: <20170511022036.32225-1-eblake@redhat.com> <20170511022036.32225-10-eblake@redhat.com> From: John Snow Message-ID: <820d73f3-7b3f-83f2-d418-cdec96e665d8@redhat.com> Date: Mon, 5 Jun 2017 18:23:17 -0400 MIME-Version: 1.0 In-Reply-To: <20170511022036.32225-10-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/20] mirror: Update signature of mirror_clip_sectors() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , qemu-block@nongnu.org, Max Reitz On 05/10/2017 10:20 PM, Eric Blake wrote: > Rather than having a void function that modifies its input > in-place as the output, change the signature to reduce a layer > of indirection and return the result. > > Suggested-by: John Snow > Signed-off-by: Eric Blake > Reviewed-by: John Snow > --- > v2: new patch > --- > block/mirror.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >