qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Daniel Henrique Barboza <danielhb413@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
	Greg Kurz <groug@kaod.org>,
	Harsh Prateek Bora <harshpb@linux.ibm.com>
Subject: Re: [PATCH v3] target/ppc: Machine check on invalid real address access on POWER9/10
Date: Thu, 6 Jul 2023 22:55:29 +0200	[thread overview]
Message-ID: <82163867-c39f-db16-7c6a-f77bcc5d475e@kaod.org> (raw)
In-Reply-To: <ba50f55b-1c48-df50-a16c-95f0f51f48f8@gmail.com>

On 7/6/23 22:50, Daniel Henrique Barboza wrote:
> 
> 
> On 7/6/23 04:32, Nicholas Piggin wrote:
>> On Mon Jul 3, 2023 at 10:03 PM AEST, Nicholas Piggin wrote:
>>> ppc currently silently accepts invalid real address access. Catch
>>> these and turn them into machine checks on POWER9/10 machines.
>>
>> Would there be any objections to merging this and the checkstop patch?
>> We could disable this one before release if it turns out to cause
>> breakage.
> 
> I don't have objections but his bad boy has no acks.
> 
> Cedric, if you vouch for this change send a R-b and I'll queue this up.


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> 
> 
> Thanks,
> 
> 
> Daniel
> 
>>
>> I don't think it needs to rebase, and passes clang build and make check
>> here. Just messed up the separator on the changelog of the checkstop
>> patch.
>>
>> Thanks,
>> Nick
>>
>>
>>>
>>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>>> ---
>>> Since v1:
>>> - Only implement this for POWER9/10. Seems like previous IBM processors
>>>    may not catch this, trying to get info.
>>>
>>> Since v2:
>>> - Split out from larger series since it is independent.



  reply	other threads:[~2023-07-06 20:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 12:03 [PATCH v3] target/ppc: Machine check on invalid real address access on POWER9/10 Nicholas Piggin
2023-07-06  7:32 ` Nicholas Piggin
2023-07-06  7:50   ` Cédric Le Goater
2023-07-06 11:43     ` BALATON Zoltan
2023-07-06 11:54       ` BALATON Zoltan
2023-07-06 13:10       ` Cédric Le Goater
2023-07-06 20:50   ` Daniel Henrique Barboza
2023-07-06 20:55     ` Cédric Le Goater [this message]
2023-07-07  7:20 ` Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82163867-c39f-db16-7c6a-f77bcc5d475e@kaod.org \
    --to=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=harshpb@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).