From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, Janosch Frank <frankja@linux.ibm.com>
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [kvm-unit-tests PATCH v3] s390x: Add stsi 3.2.2 tests
Date: Tue, 31 Mar 2020 19:24:31 +0200 [thread overview]
Message-ID: <82274eb6-2634-3400-b039-8fb49df6250e@redhat.com> (raw)
In-Reply-To: <20200331113535.6bbd434d.cohuck@redhat.com>
On 31.03.20 11:35, Cornelia Huck wrote:
> On Tue, 31 Mar 2020 03:14:56 -0400
> Janosch Frank <frankja@linux.ibm.com> wrote:
>
>> Subcode 3.2.2 is handled by KVM/QEMU and should therefore be tested
>> a bit more thorough.
>
> s/thorough/thoroughly/ ?
I fixed that up for now.
[...]
>> + if (data->vm[0].ext_name_encoding != 2) {
>> + report_skip("Extended VM names are not UTF-8.");
>
> Do we expect this to be anything other than UTF-8?
I'm not a fan of hard-coding things that can change to other valid
values. No strong feelings though. I'll let Janosch decide :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-03-31 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2ebc49ff-479a-351d-36f9-cb79fe4b9804@redhat.com>
2020-03-31 7:14 ` [kvm-unit-tests PATCH v3] s390x: Add stsi 3.2.2 tests Janosch Frank
2020-03-31 8:24 ` David Hildenbrand
2020-03-31 8:29 ` Janosch Frank
2020-03-31 8:38 ` David Hildenbrand
2020-03-31 9:35 ` Cornelia Huck
2020-03-31 9:46 ` Janosch Frank
2020-03-31 10:16 ` Cornelia Huck
2020-03-31 10:45 ` Janosch Frank
2020-03-31 17:24 ` David Hildenbrand [this message]
2020-04-01 7:20 ` Janosch Frank
2020-04-01 7:24 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82274eb6-2634-3400-b039-8fb49df6250e@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).