From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8VDW-00077i-2a for qemu-devel@nongnu.org; Tue, 17 Apr 2018 14:20:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8VDT-0004WL-Gk for qemu-devel@nongnu.org; Tue, 17 Apr 2018 14:20:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40348 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8VDT-0004VD-AF for qemu-devel@nongnu.org; Tue, 17 Apr 2018 14:20:31 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3HIJDDQ043577 for ; Tue, 17 Apr 2018 14:20:29 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hdnm4sh5q-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 14:20:28 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 14:20:27 -0400 References: <1523819244-29954-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1523819244-29954-4-git-send-email-akrowiak@linux.vnet.ibm.com> <1808b8f3-9cff-c849-d012-b23f29d1c11f@redhat.com> From: Tony Krowiak Date: Tue, 17 Apr 2018 14:20:21 -0400 MIME-Version: 1.0 In-Reply-To: <1808b8f3-9cff-c849-d012-b23f29d1c11f@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Message-Id: <822b2b72-cbda-335b-1ea4-2a1df075ec4d@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, bjsdjshi@linux.vnet.ibm.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com, eskultet@redhat.com, berrange@redhat.com, alex.williamson@redhat.com, eric.auger@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, agraf@suse.de, rth@twiddle.net On 04/16/2018 11:44 AM, David Hildenbrand wrote: >> >> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c >> index 0cdbc15..0d5b0f7 100644 >> --- a/target/s390x/gen-features.c >> +++ b/target/s390x/gen-features.c >> @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] = { >> S390_FEAT_ADAPTER_INT_SUPPRESSION, >> S390_FEAT_EDAT_2, >> S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2, >> + S390_FEAT_AP_QUERY_CONFIG_INFO, >> + S390_FEAT_AP_FACILITIES_TEST, >> + S390_FEAT_AP, >> }; >> > Now I have to ask a very stupid question: > > I heard that the execution controls in the SIE block for AP are one of > the oldest ones we have around. How can it be that the AP feature cannot > be used before zEC12? Its not a stupid question, but I don't have an answer because this was not a design decision I made. I will consult with the crypto team to see if I can get you an answer. > >