From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87CEAC433EF for ; Tue, 21 Jun 2022 10:02:00 +0000 (UTC) Received: from localhost ([::1]:33436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3ahq-0000Lv-2g for qemu-devel@archiver.kernel.org; Tue, 21 Jun 2022 06:01:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3afS-0006Vw-S6; Tue, 21 Jun 2022 05:59:30 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:62634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3afQ-0000zS-KG; Tue, 21 Jun 2022 05:59:30 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25L7uEop021372; Tue, 21 Jun 2022 09:59:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=jLvTheEv+MKWhJz2W+N4niw1xGD31AReJsSlK66R8zg=; b=jT3zpGEgiHqcPSzxGSQ/S0QPjdXzqc7pRGfwAInVaK2BQAuEAzvKmkvxwDaWrqzSu40p Ryd5RVlnduEm/IbgsTRc3uDHQM3pQm9sKNH0s7yLL+yw6M5JQPOC5Tn0BgEQP9sM/eV0 PV75zWI0aREUPESi93W5yJNKjaPX+JZDD9e7ieEYumM2HIsvjQcTthg5wmk39oF0XYh2 dWxaZKpSTEALjOnOOqaClF/PC2XQZFrV2ykEb3dYxbk7tGBVtPI9FhlDSA8Hc206Fy/b ricwVab7sMBZpEqYg5DMTnoq7KCRkec3vDBm8iJMX+W4c7Xgg7fmg1tH6Db+w8qt97Li pA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gua1cuama-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 09:59:18 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 25L9FrUA007198; Tue, 21 Jun 2022 09:59:17 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gua1cuakm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 09:59:17 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25L9op56022722; Tue, 21 Jun 2022 09:59:15 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma06ams.nl.ibm.com with ESMTP id 3gs5yhktaa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 09:59:15 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25L9xDZ314221638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 09:59:13 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1833E11C04A; Tue, 21 Jun 2022 09:59:13 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A080511C04C; Tue, 21 Jun 2022 09:59:12 +0000 (GMT) Received: from [9.145.155.216] (unknown [9.145.155.216]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 21 Jun 2022 09:59:12 +0000 (GMT) Message-ID: <822f2039-be47-9d8f-fefd-4cd73bd6c8d7@linux.ibm.com> Date: Tue, 21 Jun 2022 11:59:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 8/9] ppc/pnv: remove 'INTERFACE_PCIE_DEVICE' from phb3 root bus Content-Language: en-US To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, clg@kaod.org References: <20220618110202.87735-1-danielhb413@gmail.com> <20220618110202.87735-9-danielhb413@gmail.com> From: Frederic Barrat In-Reply-To: <20220618110202.87735-9-danielhb413@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JUeGBm9yjE8_m5N2kYeADyc6ZuzHRvs5 X-Proofpoint-GUID: 6gchPNVuPLL8PEicjW4Roof1wHPec_7i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-21_04,2022-06-17_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206210041 Received-SPF: pass client-ip=148.163.156.1; envelope-from=fbarrat@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/06/2022 13:02, Daniel Henrique Barboza wrote: > It's unneeded. No other PCIE_BUS implements this interface. > > Fixes: 9ae1329ee2fe ("ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge") > Signed-off-by: Daniel Henrique Barboza > --- It seems indeed not needed. Reviewed-by: Frederic Barrat Fred > hw/pci-host/pnv_phb3.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c > index 8c03cc94f2..696c9bef26 100644 > --- a/hw/pci-host/pnv_phb3.c > +++ b/hw/pci-host/pnv_phb3.c > @@ -1129,10 +1129,6 @@ static const TypeInfo pnv_phb3_root_bus_info = { > .name = TYPE_PNV_PHB3_ROOT_BUS, > .parent = TYPE_PCIE_BUS, > .class_init = pnv_phb3_root_bus_class_init, > - .interfaces = (InterfaceInfo[]) { > - { INTERFACE_PCIE_DEVICE }, > - { } > - }, > }; > > static void pnv_phb3_root_port_realize(DeviceState *dev, Error **errp)