From: Thomas Huth <thuth@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: philmd@linaro.org, Gerd Hoffmann <kraxel@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] ui/dbus: fix clang compilation issue
Date: Wed, 26 Jul 2023 17:15:26 +0200 [thread overview]
Message-ID: <8242fc5c-4c73-a3e1-8f80-3e24ab341e14@redhat.com> (raw)
In-Reply-To: <20230726151221.515761-1-marcandre.lureau@redhat.com>
On 26/07/2023 17.12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> ../ui/dbus-listener.c:236:9: error: expected expression
> Error *err = NULL;
>
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/dbus-listener.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
> index 02fc6ae239..30917271ab 100644
> --- a/ui/dbus-listener.c
> +++ b/ui/dbus-listener.c
> @@ -232,7 +232,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
> egl_fb_read_rect(ddl->ds, &ddl->fb, x, y, w, h);
> dbus_gfx_update(dcl, x, y, w, h);
> break;
> - case SHARE_KIND_D3DTEX:
> + case SHARE_KIND_D3DTEX: {
> Error *err = NULL;
> assert(ddl->d3d_texture);
>
> @@ -249,6 +249,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
> dbus_update_gl_cb,
> g_object_ref(ddl));
> break;
> + }
> default:
> g_warn_if_reached();
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-07-26 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 15:12 [PATCH] ui/dbus: fix clang compilation issue marcandre.lureau
2023-07-26 15:15 ` Thomas Huth [this message]
2023-07-31 9:24 ` Philippe Mathieu-Daudé
2023-08-01 21:44 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8242fc5c-4c73-a3e1-8f80-3e24ab341e14@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).