From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFmLj-0001Rk-JC for qemu-devel@nongnu.org; Thu, 25 Oct 2018 16:35:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFmFL-0006HH-DG for qemu-devel@nongnu.org; Thu, 25 Oct 2018 16:28:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53866) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gFmFL-0006GG-4n for qemu-devel@nongnu.org; Thu, 25 Oct 2018 16:28:47 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8469F30001DF for ; Thu, 25 Oct 2018 20:28:46 +0000 (UTC) References: <20181025085256.20522-1-kraxel@redhat.com> <20181025085256.20522-4-kraxel@redhat.com> From: Thomas Huth Message-ID: <824b1ea0-525f-e912-a610-61cc0896d86d@redhat.com> Date: Thu, 25 Oct 2018 21:28:40 +0100 MIME-Version: 1.0 In-Reply-To: <20181025085256.20522-4-kraxel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Prasad J Pandit On 2018-10-25 09:52, Gerd Hoffmann wrote: > While being at it deprecate cirrus too. > > Reason (short version): use stdvga instead. > Verbose version: > https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful > > Signed-off-by: Gerd Hoffmann > --- > hw/display/cirrus_vga.c | 2 ++ > hw/display/cirrus_vga_isa.c | 2 ++ > qemu-deprecated.texi | 4 ++++ > 3 files changed, 8 insertions(+) > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > index d9b854d..2f16ba9 100644 > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -3024,6 +3024,8 @@ static void cirrus_vga_class_init(ObjectClass *klass, void *data) > dc->vmsd = &vmstate_pci_cirrus_vga; > dc->props = pci_vga_cirrus_properties; > dc->hotpluggable = false; > + dc->deprecation_reason = > + "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful"; > } > > static const TypeInfo cirrus_vga_info = { > diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c > index fa10b74..c2d853c 100644 > --- a/hw/display/cirrus_vga_isa.c > +++ b/hw/display/cirrus_vga_isa.c > @@ -81,6 +81,8 @@ static void isa_cirrus_vga_class_init(ObjectClass *klass, void *data) > dc->realize = isa_cirrus_vga_realizefn; > dc->props = isa_cirrus_vga_properties; > set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > + dc->deprecation_reason = > + "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful"; > } > > static const TypeInfo isa_cirrus_vga_info = { > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 7951a4f..1b1d434 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -120,6 +120,10 @@ or ``ivshmem-doorbell`` device types. > > Has known buffer overflow. > > +@subsection cirrus (since 3.1) > + > +Use stdvga instead (-vga std or -device VGA). > + > @section System emulator machines > > @subsection pc-0.10 and pc-0.11 (since 3.0) > Reviewed-by: Thomas Huth