From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
stefanha@redhat.com, jsnow@redhat.com, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests
Date: Mon, 31 Jul 2017 09:53:02 -0500 [thread overview]
Message-ID: <825806a4-9ea7-aa92-c1f6-4c625dc01de0@redhat.com> (raw)
In-Reply-To: <c2c3ec73f07ce7181cf71ad8d0d91811c48ea283.1501508049.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On 07/31/2017 08:47 AM, Jeff Cody wrote:
> All files for a given test are now self-contained in a subdirectory,
> and therefore the "./check" script can do all file-related cleanup
> without any help.
>
> This removes file cleanups from the bash tests. The only cleanup left
> is whatever is needed to kill any spawned processes; e.g. _cleanup_qemu.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
Based on cover letter description of diff from v1, you addressed my
concerns.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-31 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 13:47 [Qemu-devel] [PATCH v2 for-2.11 0/3] qemu-iotests: place output in unique dir Jeff Cody
2017-07-31 13:47 ` [Qemu-devel] [PATCH v2 for-2.11 1/3] qemu-iotests: set TEST_DIR to a unique dir for each test Jeff Cody
2017-07-31 14:44 ` Eric Blake
2017-07-31 15:07 ` Jeff Cody
2017-07-31 13:47 ` [Qemu-devel] [PATCH v2 for-2.11 2/3] qemu-iotests: remove file cleanup from bash tests Jeff Cody
2017-07-31 14:53 ` Eric Blake [this message]
2017-07-31 13:47 ` [Qemu-devel] [PATCH v2 for-2.11 3/3] qemu-iotests: add option to save temp files on error Jeff Cody
2017-08-01 6:34 ` Markus Armbruster
2017-08-01 21:42 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=825806a4-9ea7-aa92-c1f6-4c625dc01de0@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).