From: Thomas Huth <thuth@redhat.com>
To: Gustavo Romero <gustavo.romero@linaro.org>,
qemu-devel@nongnu.org, alex.bennee@linaro.org,
berrange@redhat.com
Cc: qemu-arm@nongnu.org, manos.pitsidianakis@linaro.org,
peter.maydell@linaro.org
Subject: Re: [PATCH v4 1/9] tests/functional: Re-activate the check-venv target
Date: Fri, 26 Sep 2025 08:28:26 +0200 [thread overview]
Message-ID: <825b38e7-dca5-44c5-b73b-ae2ac740ccb6@redhat.com> (raw)
In-Reply-To: <20250926051542.104432-2-gustavo.romero@linaro.org>
On 26/09/2025 07.15, Gustavo Romero wrote:
> Add check-venv target as a dependency for the functional tests. This
> causes Python modules listed in pythondeps.toml, under the testdeps
> group, to be installed when 'make check-functional' is executed to
> prepare and run the functional tests.
>
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 3538c0c740..d012a9b25d 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -109,7 +109,7 @@ $(FUNCTIONAL_TARGETS):
> @$(MAKE) SPEED=thorough $(subst -functional,-func,$@)
>
> .PHONY: check-functional
> -check-functional:
> +check-functional: check-venv
> @$(NINJA) precache-functional
> @QEMU_TEST_NO_DOWNLOAD=1 $(MAKE) SPEED=thorough check-func check-func-quick
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-09-26 6:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 5:15 [PATCH v4 0/9] tests/functional: Adapt reverse_debugging to run w/o Avocado Gustavo Romero
2025-09-26 5:15 ` [PATCH v4 1/9] tests/functional: Re-activate the check-venv target Gustavo Romero
2025-09-26 6:28 ` Thomas Huth [this message]
2025-09-26 8:34 ` Thomas Huth
2025-09-26 8:37 ` Daniel P. Berrangé
2025-09-26 8:42 ` Thomas Huth
2025-09-26 8:50 ` Daniel P. Berrangé
2025-09-26 15:44 ` Gustavo Romero
2025-09-26 15:47 ` Daniel P. Berrangé
2025-09-26 16:02 ` Gustavo Romero
2025-09-26 15:43 ` Gustavo Romero
2025-09-29 6:26 ` Thomas Huth
2025-09-29 6:29 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 2/9] python: Install pygdbmi in meson's venv Gustavo Romero
2025-09-26 6:28 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 3/9] tests/functional: Provide GDB to the functional tests Gustavo Romero
2025-09-26 10:03 ` Thomas Huth
2025-09-26 18:08 ` Gustavo Romero
2025-09-26 18:15 ` Gustavo Romero
2025-09-29 6:34 ` Thomas Huth
2025-09-29 8:03 ` Daniel P. Berrangé
2025-09-26 5:15 ` [PATCH v4 4/9] tests/functional: Add GDB class Gustavo Romero
2025-09-26 7:05 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 5/9] tests/functional: replace avocado process with subprocess Gustavo Romero
2025-09-26 7:10 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 6/9] tests/functional: drop datadrainer class in reverse debugging Gustavo Romero
2025-09-26 7:13 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 7/9] tests/functional: Add decorator to skip test on missing env vars Gustavo Romero
2025-09-26 7:20 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 8/9] tests/functional: Adapt reverse_debugging to run w/o Avocado Gustavo Romero
2025-09-26 8:44 ` Thomas Huth
2025-09-26 16:00 ` Gustavo Romero
2025-09-29 6:24 ` Thomas Huth
2025-09-26 5:15 ` [PATCH v4 9/9] tests/functional: Adapt arches to reverse_debugging " Gustavo Romero
2025-09-26 9:09 ` Thomas Huth
2025-09-26 6:49 ` [PATCH v4 0/9] tests/functional: Adapt reverse_debugging to run " Philippe Mathieu-Daudé
2025-09-26 9:14 ` Thomas Huth
2025-09-26 9:32 ` Philippe Mathieu-Daudé
2025-09-26 9:41 ` Daniel P. Berrangé
2025-09-26 9:42 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=825b38e7-dca5-44c5-b73b-ae2ac740ccb6@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=gustavo.romero@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).