From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>, shorne@gmail.com
Subject: Re: [Qemu-devel] [PATCH 14/22] target/openrisc: Set flags on helpers
Date: Thu, 9 Feb 2017 02:16:11 -0300 [thread overview]
Message-ID: <825ead35-bcdf-89a0-e90c-d2122d608294@gmail.com> (raw)
In-Reply-To: <20170209045154.16868-15-rth@twiddle.net>
On 02/09/2017 01:51 AM, Richard Henderson wrote:
> Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/openrisc/helper.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/target/openrisc/helper.h b/target/openrisc/helper.h
> index f4d97a2..78a123d 100644
> --- a/target/openrisc/helper.h
> +++ b/target/openrisc/helper.h
> @@ -18,26 +18,26 @@
> */
>
> /* exception */
> -DEF_HELPER_FLAGS_2(exception, 0, void, env, i32)
> +DEF_HELPER_FLAGS_2(exception, TCG_CALL_NO_WG, void, env, i32)
> DEF_HELPER_FLAGS_1(ove_cy, TCG_CALL_NO_WG, void, env)
> DEF_HELPER_FLAGS_1(ove_ov, TCG_CALL_NO_WG, void, env)
> DEF_HELPER_FLAGS_1(ove_cyov, TCG_CALL_NO_WG, void, env)
>
> /* float */
> -DEF_HELPER_FLAGS_2(itofd, 0, i64, env, i64)
> -DEF_HELPER_FLAGS_2(itofs, 0, i32, env, i32)
> -DEF_HELPER_FLAGS_2(ftoid, 0, i64, env, i64)
> -DEF_HELPER_FLAGS_2(ftois, 0, i32, env, i32)
> +DEF_HELPER_FLAGS_2(itofd, TCG_CALL_NO_WG, i64, env, i64)
> +DEF_HELPER_FLAGS_2(itofs, TCG_CALL_NO_WG, i32, env, i32)
> +DEF_HELPER_FLAGS_2(ftoid, TCG_CALL_NO_WG, i64, env, i64)
> +DEF_HELPER_FLAGS_2(ftois, TCG_CALL_NO_WG, i32, env, i32)
>
> #define FOP_MADD(op) \
> -DEF_HELPER_FLAGS_3(float_ ## op ## _s, 0, i32, env, i32, i32) \
> -DEF_HELPER_FLAGS_3(float_ ## op ## _d, 0, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(float_ ## op ## _s, TCG_CALL_NO_WG, i32, env, i32, i32) \
> +DEF_HELPER_FLAGS_3(float_ ## op ## _d, TCG_CALL_NO_WG, i64, env, i64, i64)
> FOP_MADD(muladd)
> #undef FOP_MADD
>
> #define FOP_CALC(op) \
> -DEF_HELPER_FLAGS_3(float_ ## op ## _s, 0, i32, env, i32, i32) \
> -DEF_HELPER_FLAGS_3(float_ ## op ## _d, 0, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(float_ ## op ## _s, TCG_CALL_NO_WG, i32, env, i32, i32) \
> +DEF_HELPER_FLAGS_3(float_ ## op ## _d, TCG_CALL_NO_WG, i64, env, i64, i64)
> FOP_CALC(add)
> FOP_CALC(sub)
> FOP_CALC(mul)
> @@ -46,8 +46,8 @@ FOP_CALC(rem)
> #undef FOP_CALC
>
> #define FOP_CMP(op) \
> -DEF_HELPER_FLAGS_3(float_ ## op ## _s, 0, i32, env, i32, i32) \
> -DEF_HELPER_FLAGS_3(float_ ## op ## _d, 0, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(float_ ## op ## _s, TCG_CALL_NO_WG, i32, env, i32, i32) \
> +DEF_HELPER_FLAGS_3(float_ ## op ## _d, TCG_CALL_NO_WG, i64, env, i64, i64)
> FOP_CMP(eq)
> FOP_CMP(lt)
> FOP_CMP(le)
> @@ -61,4 +61,4 @@ DEF_HELPER_FLAGS_1(rfe, 0, void, env)
>
> /* sys */
> DEF_HELPER_FLAGS_4(mtspr, 0, void, env, tl, tl, tl)
> -DEF_HELPER_FLAGS_4(mfspr, 0, tl, env, tl, tl, tl)
> +DEF_HELPER_FLAGS_4(mfspr, TCG_CALL_NO_WG, tl, env, tl, tl, tl)
>
next prev parent reply other threads:[~2017-02-09 5:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 4:51 [Qemu-devel] [PATCH 00/22] target/openrisc updates Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 01/22] target/openrisc: Rename the cpu from or32 to or1k Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 03/22] linux-user: Fix openrisc cpu_loop Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 04/22] target/openrisc: Fix exception handling status registers Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 05/22] target/openrisc: Implement lwa, swa Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 06/22] target/openrisc: Tidy insn dumping Richard Henderson
2017-02-09 5:14 ` Philippe Mathieu-Daudé
2017-02-09 4:51 ` [Qemu-devel] [PATCH 07/22] target/openrisc: Rationalize immediate extraction Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 08/22] target/openrisc: Streamline arithmetic and OVE Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 09/22] target/openrisc: Put SR[OVE] in TB flags Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 10/22] target/openrisc: Invert the decoding in dec_calc Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 11/22] target/openrisc: Keep SR_F in a separate variable Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 12/22] target/openrisc: Keep SR_CY and SR_OV in a separate variables Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 13/22] target/openrisc: Use movcond where appropriate Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 14/22] target/openrisc: Set flags on helpers Richard Henderson
2017-02-09 5:16 ` Philippe Mathieu-Daudé [this message]
2017-02-09 4:51 ` [Qemu-devel] [PATCH 15/22] target/openrisc: Enable trap, csync, msync, psync for user mode Richard Henderson
2017-02-09 5:24 ` Philippe Mathieu-Daudé
2017-02-09 4:51 ` [Qemu-devel] [PATCH 16/22] target/openrisc: Implement msync Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 17/22] target/openrisc: Represent MACHI:MACLO as a single unit Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 18/22] target/openrisc: Implement muld, muldu, macu, msbu Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 19/22] target/openrisc: Fix madd Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 20/22] target/openrisc: Optimize l.jal to next Richard Henderson
2017-02-09 5:20 ` Philippe Mathieu-Daudé
2017-02-09 4:51 ` [Qemu-devel] [PATCH 21/22] target/openrisc: Tidy ppc/npc implementation Richard Henderson
2017-02-09 4:51 ` [Qemu-devel] [PATCH 22/22] target/openrisc: Tidy handling of delayed branches Richard Henderson
2017-02-10 0:01 ` [Qemu-devel] [PATCH 23/22] linux-user: Honor CLONE_SETTLS for openrisc Richard Henderson
2017-02-10 0:44 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=825ead35-bcdf-89a0-e90c-d2122d608294@gmail.com \
--to=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).