From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH] disas/sh4: Add missing fallthrough annotations
Date: Thu, 9 Jul 2020 09:13:30 -0700 [thread overview]
Message-ID: <8267e832-ef6d-6ed2-cc70-5a17d5577ee3@linaro.org> (raw)
In-Reply-To: <20200630055953.9309-1-thuth@redhat.com>
On 6/29/20 10:59 PM, Thomas Huth wrote:
> Add fallthrough annotations to be able to compile the code without
> warnings with -Wimplicit-fallthrough. Looking at the code, it seems
> like the fallthrough is indeed intended here, so the comments should
> be appropriate.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> Note: The new lines use TABs since all the surounding code uses TABs, too.
> Please ignore the checkpatch warnings.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-07-09 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 5:59 [PATCH] disas/sh4: Add missing fallthrough annotations Thomas Huth
2020-06-30 6:08 ` no-reply
2020-07-09 16:13 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8267e832-ef6d-6ed2-cc70-5a17d5577ee3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).