From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCmJX-0004Rs-5D for qemu-devel@nongnu.org; Wed, 17 Oct 2018 09:56:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCmJT-0008E2-Ri for qemu-devel@nongnu.org; Wed, 17 Oct 2018 09:56:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57324) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gCmJT-0008Cs-Ft for qemu-devel@nongnu.org; Wed, 17 Oct 2018 09:56:39 -0400 References: <27268f8d488b4ec134a4475139bf0b50459cbf96.1539259394.git.artem.k.pisarenko@gmail.com> From: Eric Blake Message-ID: <827158db-f382-abca-7bae-0f2ddd390cbd@redhat.com> Date: Wed, 17 Oct 2018 08:56:36 -0500 MIME-Version: 1.0 In-Reply-To: <27268f8d488b4ec134a4475139bf0b50459cbf96.1539259394.git.artem.k.pisarenko@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] vl, qapi: offset value calculation in RTC_CHANGE event reverted to match behavior before #1797033 bugfix and documented List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artem Pisarenko , qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini On 10/11/18 7:23 AM, Artem Pisarenko wrote: > Return value of qemu_timedate_diff(), used for calculation offset in QAPI 'RTC_CHANGE' event restored to keep compatibility, although it isn't documented that difference is relative to host clock advancement. Long line. Remember to manually wrap commit messages around 70 columns or so, so that they still fit in an 80-column window under 'git log' which adds leading indentation. Also, the subject line is way too long (there, you should target 60 columns or less; 'git shortlog -30' will give you some ideas of typical summaries). > Added important note to 'RTC_CHANGE' event description to highlight established implementation specifics. > > Signed-off-by: Artem Pisarenko > --- > qapi/misc.json | 3 ++- > vl.c | 10 +++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/qapi/misc.json b/qapi/misc.json > index ada9af5..ed866f2 100644 > --- a/qapi/misc.json > +++ b/qapi/misc.json > @@ -3070,7 +3070,8 @@ > # Emitted when the guest changes the RTC time. > # > # @offset: offset between base RTC clock (as specified by -rtc base), and > -# new RTC clock value > +# new RTC clock value. Note that value will be different depending > +# on clock choosen to drive RTC (specified by -rtc clock). s/choosen/chosen/ -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org