From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59037)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UjyHG-0004nl-1C
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 16:56:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UjyHE-0007ve-T2
	for qemu-devel@nongnu.org; Tue, 04 Jun 2013 16:56:21 -0400
Date: Tue, 4 Jun 2013 16:56:17 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <827414769.14303662.1370379377725.JavaMail.root@redhat.com>
In-Reply-To: <CAFEAcA9oj-yCdsQck4oJPc__MyfrroMB2aFKSxTx1=PYfS2WCw@mail.gmail.com>
References: <1370377419-31788-1-git-send-email-alevy@redhat.com>
	<1370377419-31788-2-git-send-email-alevy@redhat.com>
	<CAFEAcA9oj-yCdsQck4oJPc__MyfrroMB2aFKSxTx1=PYfS2WCw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/5] use qemu_pipe_non_block
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

> On 4 June 2013 21:23, Alon Levy <alevy@redhat.com> wrote:
> > --- a/hw/display/qxl.c
> > +++ b/hw/display/qxl.c
> > @@ -1797,15 +1797,11 @@ static void qxl_send_events(PCIQXLDevice *d,
> > uint32_t events)
> >
> >  static void init_pipe_signaling(PCIQXLDevice *d)
> >  {
> > -    if (pipe(d->pipe) < 0) {
> > -        fprintf(stderr, "%s:%s: qxl pipe creation failed\n",
> > -                __FILE__, __func__);
> > +    if (qxl_pipe_non_block(d->pipe)) {
> 
> Surely this can't compile? -- this function doesn't exist.

I am abusing my right to post to this list, sorry. I didn't actually try to compile.

> 
> thanks
> -- PMM
> 
>