From: Eric Blake <eblake@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Richard W.M. Jones" <rjones@redhat.com>,
qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Max Reitz" <mreitz@redhat.com>,
"Liu Yuan" <namei.unix@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events
Date: Thu, 13 Dec 2018 10:34:12 -0600 [thread overview]
Message-ID: <827ac081-587f-d365-b682-3a65271a0a4a@redhat.com> (raw)
In-Reply-To: <20181213162727.17438-2-lvivier@redhat.com>
On 12/13/18 10:27 AM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>
> Notes:
> v2: use %zu with size_t
> change an uint64_t to int64_t to match % PRIi64
Why PRIi64? It's identical to PRId64, but the sources show a strong
preference for %d over %i:
$ git grep PRIi[0-9] | wc
25 172 1885
$ git grep PRId[0-9] | wc
415 3991 40345
$ git grep '%i' | wc
231 1664 18269
$ git grep '%d' | wc
5492 46211 498225
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-12-13 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 16:27 [Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event Laurent Vivier
2018-12-13 16:27 ` [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events Laurent Vivier
2018-12-13 16:34 ` Eric Blake [this message]
2018-12-13 16:49 ` Laurent Vivier
2019-01-14 11:15 ` Max Reitz
2019-01-14 11:23 ` Philippe Mathieu-Daudé
2018-12-13 16:27 ` [Qemu-devel] [PATCH v2 2/4] block/curl: " Laurent Vivier
2018-12-13 16:27 ` [Qemu-devel] [PATCH v2 3/4] block/file-posix: " Laurent Vivier
2018-12-13 16:27 ` [Qemu-devel] [PATCH v2 4/4] block/sheepdog: " Laurent Vivier
2019-01-14 11:51 ` Max Reitz
2019-01-14 12:14 ` [Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event Max Reitz
2019-01-14 12:26 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=827ac081-587f-d365-b682-3a65271a0a4a@redhat.com \
--to=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=namei.unix@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).