From: "Cédric Le Goater" <clg@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH for-10.2] hw/arm/virt: Include 'system/system.h'
Date: Tue, 5 Aug 2025 22:00:58 +0200 [thread overview]
Message-ID: <82833ff9-1f78-4929-82d6-f59a3b056626@redhat.com> (raw)
In-Reply-To: <f9a79dda-83a8-4cbf-9a3d-dde4fcc0eb48@linaro.org>
On 8/5/25 16:16, Philippe Mathieu-Daudé wrote:
> On 31/7/25 16:40, Cédric Le Goater wrote:
>> hw/arm/virt.c should include 'system/system.h' for :
>>
>> serial_hd()
>
> 3 other files miss it:
>
> $ git grep -L system/system $(git grep -wl serial_hd)
> hw/arm/virt.c
> hw/isa/isa-superio.c
> hw/mips/loongson3_virt.c
> hw/mips/malta.c
> include/system/system.h
OK. This deserves a v2. Will work on it.
Thanks,
C.
prev parent reply other threads:[~2025-08-05 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 14:40 [PATCH for-10.2] hw/arm/virt: Include 'system/system.h' Cédric Le Goater
2025-07-31 14:55 ` Peter Maydell
2025-07-31 15:05 ` Cédric Le Goater
2025-08-05 14:16 ` Philippe Mathieu-Daudé
2025-08-05 20:00 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82833ff9-1f78-4929-82d6-f59a3b056626@redhat.com \
--to=clg@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).