* [PATCH for-10.2] hw/arm/virt: Include 'system/system.h'
@ 2025-07-31 14:40 Cédric Le Goater
2025-07-31 14:55 ` Peter Maydell
2025-08-05 14:16 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 5+ messages in thread
From: Cédric Le Goater @ 2025-07-31 14:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-arm, Peter Maydell, Cédric Le Goater
hw/arm/virt.c should include 'system/system.h' for :
serial_hd()
qemu_add_machine_init_done_notifier()
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/arm/virt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index ef6be3660f5fb38da84235c32dc2d13a5c61889c..e1b6241f7bee4c2fddde31c512561e87229cebc2 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -50,6 +50,7 @@
#include "system/kvm.h"
#include "system/hvf.h"
#include "system/qtest.h"
+#include "system/system.h"
#include "hw/loader.h"
#include "qapi/error.h"
#include "qemu/bitops.h"
--
2.50.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH for-10.2] hw/arm/virt: Include 'system/system.h'
2025-07-31 14:40 [PATCH for-10.2] hw/arm/virt: Include 'system/system.h' Cédric Le Goater
@ 2025-07-31 14:55 ` Peter Maydell
2025-07-31 15:05 ` Cédric Le Goater
2025-08-05 14:16 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2025-07-31 14:55 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-devel, qemu-arm
On Thu, 31 Jul 2025 at 15:40, Cédric Le Goater <clg@redhat.com> wrote:
>
> hw/arm/virt.c should include 'system/system.h' for :
>
> serial_hd()
> qemu_add_machine_init_done_notifier()
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index ef6be3660f5fb38da84235c32dc2d13a5c61889c..e1b6241f7bee4c2fddde31c512561e87229cebc2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -50,6 +50,7 @@
> #include "system/kvm.h"
> #include "system/hvf.h"
> #include "system/qtest.h"
> +#include "system/system.h"
> #include "hw/loader.h"
> #include "qapi/error.h"
> #include "qemu/bitops.h"
Presumably we're currently pulling in this header
indirectly via some other header (the vfio ones)?
Might be helpful to say which.
If this is a dependency for your vfio-platform removal
patches, feel free to include it in there.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-10.2] hw/arm/virt: Include 'system/system.h'
2025-07-31 14:55 ` Peter Maydell
@ 2025-07-31 15:05 ` Cédric Le Goater
0 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2025-07-31 15:05 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, qemu-arm
On 7/31/25 16:55, Peter Maydell wrote:
> On Thu, 31 Jul 2025 at 15:40, Cédric Le Goater <clg@redhat.com> wrote:
>>
>> hw/arm/virt.c should include 'system/system.h' for :
>>
>> serial_hd()
>> qemu_add_machine_init_done_notifier()
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>> hw/arm/virt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> index ef6be3660f5fb38da84235c32dc2d13a5c61889c..e1b6241f7bee4c2fddde31c512561e87229cebc2 100644
>> --- a/hw/arm/virt.c
>> +++ b/hw/arm/virt.c
>> @@ -50,6 +50,7 @@
>> #include "system/kvm.h"
>> #include "system/hvf.h"
>> #include "system/qtest.h"
>> +#include "system/system.h"
>> #include "hw/loader.h"
>> #include "qapi/error.h"
>> #include "qemu/bitops.h"
>
> Presumably we're currently pulling in this header
> indirectly via some other header (the vfio ones)?
yes.
> Might be helpful to say which.
>
> If this is a dependency for your vfio-platform removal
> patches, feel free to include it in there.
I will do that and improve the commit log.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> -- PMM
>
Thanks,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-10.2] hw/arm/virt: Include 'system/system.h'
2025-07-31 14:40 [PATCH for-10.2] hw/arm/virt: Include 'system/system.h' Cédric Le Goater
2025-07-31 14:55 ` Peter Maydell
@ 2025-08-05 14:16 ` Philippe Mathieu-Daudé
2025-08-05 20:00 ` Cédric Le Goater
1 sibling, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-08-05 14:16 UTC (permalink / raw)
To: Cédric Le Goater, qemu-devel; +Cc: qemu-arm, Peter Maydell
On 31/7/25 16:40, Cédric Le Goater wrote:
> hw/arm/virt.c should include 'system/system.h' for :
>
> serial_hd()
3 other files miss it:
$ git grep -L system/system $(git grep -wl serial_hd)
hw/arm/virt.c
hw/isa/isa-superio.c
hw/mips/loongson3_virt.c
hw/mips/malta.c
include/system/system.h
Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> qemu_add_machine_init_done_notifier()
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index ef6be3660f5fb38da84235c32dc2d13a5c61889c..e1b6241f7bee4c2fddde31c512561e87229cebc2 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -50,6 +50,7 @@
> #include "system/kvm.h"
> #include "system/hvf.h"
> #include "system/qtest.h"
> +#include "system/system.h"
> #include "hw/loader.h"
> #include "qapi/error.h"
> #include "qemu/bitops.h"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH for-10.2] hw/arm/virt: Include 'system/system.h'
2025-08-05 14:16 ` Philippe Mathieu-Daudé
@ 2025-08-05 20:00 ` Cédric Le Goater
0 siblings, 0 replies; 5+ messages in thread
From: Cédric Le Goater @ 2025-08-05 20:00 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-arm, Peter Maydell
On 8/5/25 16:16, Philippe Mathieu-Daudé wrote:
> On 31/7/25 16:40, Cédric Le Goater wrote:
>> hw/arm/virt.c should include 'system/system.h' for :
>>
>> serial_hd()
>
> 3 other files miss it:
>
> $ git grep -L system/system $(git grep -wl serial_hd)
> hw/arm/virt.c
> hw/isa/isa-superio.c
> hw/mips/loongson3_virt.c
> hw/mips/malta.c
> include/system/system.h
OK. This deserves a v2. Will work on it.
Thanks,
C.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-05 20:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-31 14:40 [PATCH for-10.2] hw/arm/virt: Include 'system/system.h' Cédric Le Goater
2025-07-31 14:55 ` Peter Maydell
2025-07-31 15:05 ` Cédric Le Goater
2025-08-05 14:16 ` Philippe Mathieu-Daudé
2025-08-05 20:00 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).