From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nupr8-000769-ME
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:24:26 -0400
Received: from [140.186.70.92] (port=37055 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nupr7-00074l-37
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:24:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <camm@ualberta.ca>) id 1Nupr4-0001gV-Ot
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:24:24 -0400
Received: from mail-yw0-f198.google.com ([209.85.211.198]:43720)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <camm@ualberta.ca>) id 1Nupr4-0001fh-JZ
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:24:22 -0400
Received: by ywh36 with SMTP id 36so1886511ywh.4
	for <qemu-devel@nongnu.org>; Thu, 25 Mar 2010 09:24:21 -0700 (PDT)
MIME-Version: 1.0
Sender: camm@ualberta.ca
In-Reply-To: <4BAB30EE.4020509@redhat.com>
References: <1269497376-21903-1-git-send-email-cam@cs.ualberta.ca>
	<4BAB30EE.4020509@redhat.com>
Date: Thu, 25 Mar 2010 10:24:20 -0600
Message-ID: <8286e4ee1003250924q7cca5e71u8b8b7c6d8b785eb8@mail.gmail.com>
From: Cam Macdonell <cam@cs.ualberta.ca>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, Mar 25, 2010 at 3:46 AM, Avi Kivity <avi@redhat.com> wrote:
> On 03/25/2010 08:09 AM, Cam Macdonell wrote:
>>
>> This patch adds a driver for my shared memory PCI device using the uio_p=
ci
>> interface. =A0The driver has three memory regions. =A0The first memory r=
egion
>> is for
>> device registers for sending interrupts. The second BAR is for receiving
>> MSI-X
>> interrupts and the third memory region maps the shared memory. =A0The de=
vice
>> only
>> exports the first and third memory regions to userspace.
>>
>> This driver supports MSI-X and regular pin interrupts. =A0Currently, the
>> number of
>> MSI vectors is set to 4 which could be increased, but the driver will wo=
rk
>> with
>> fewer vectors. =A0If MSI is not available, then regular interrupts will =
be
>> used.
>>
>
> There is now a generic PCI 2.3 driver that can handle all PCI devices. =
=A0It
> doesn't support MSI, but if we add MSI support then it can be used withou=
t
> the need for a specialized driver.

Agreed, I'd be happy to use the generic driver if MSI is there.  What
would MSI support for UIO look like?  An array of "struct uio_irq" for
the different vectors?

Cam

>
> --
> error compiling committee.c: too many arguments to function
>
>