From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/9] target/xtensa: implement block prefetch option opcodes
Date: Wed, 15 May 2019 08:46:07 +0200 [thread overview]
Message-ID: <8293f332-446d-1ff7-7c69-8043568e96de@redhat.com> (raw)
In-Reply-To: <20190514204447.17486-8-jcmvbkbc@gmail.com>
On 5/14/19 10:44 PM, Max Filippov wrote:
> Block prefetch option adds a bunch of non-privileged opcodes that may be
> implemented as nops since QEMU doesn't model caches.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> target/xtensa/translate.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
> index 24eb70d619d5..356eb9948701 100644
> --- a/target/xtensa/translate.c
> +++ b/target/xtensa/translate.c
> @@ -3078,6 +3078,9 @@ static const XtensaOpcodeOps core_ops[] = {
> .translate = translate_dcache,
> .op_flags = XTENSA_OP_PRIVILEGED,
> }, {
> + .name = "dhi.b",
> + .translate = translate_nop,
> + }, {
> .name = "dhu",
> .translate = translate_dcache,
> .op_flags = XTENSA_OP_PRIVILEGED,
> @@ -3085,9 +3088,15 @@ static const XtensaOpcodeOps core_ops[] = {
> .name = "dhwb",
> .translate = translate_dcache,
> }, {
> + .name = "dhwb.b",
> + .translate = translate_nop,
> + }, {
> .name = "dhwbi",
> .translate = translate_dcache,
> }, {
> + .name = "dhwbi.b",
> + .translate = translate_nop,
> + }, {
> .name = "dii",
> .translate = translate_nop,
> .op_flags = XTENSA_OP_PRIVILEGED,
> @@ -3112,15 +3121,33 @@ static const XtensaOpcodeOps core_ops[] = {
> .translate = translate_dcache,
> .op_flags = XTENSA_OP_PRIVILEGED,
> }, {
> + .name = "dpfm.b",
> + .translate = translate_nop,
> + }, {
> + .name = "dpfm.bf",
> + .translate = translate_nop,
> + }, {
> .name = "dpfr",
> .translate = translate_nop,
> }, {
> + .name = "dpfr.b",
> + .translate = translate_nop,
> + }, {
> + .name = "dpfr.bf",
> + .translate = translate_nop,
> + }, {
> .name = "dpfro",
> .translate = translate_nop,
> }, {
> .name = "dpfw",
> .translate = translate_nop,
> }, {
> + .name = "dpfw.b",
> + .translate = translate_nop,
> + }, {
> + .name = "dpfw.bf",
> + .translate = translate_nop,
> + }, {
> .name = "dpfwo",
> .translate = translate_nop,
> }, {
> @@ -3628,6 +3655,21 @@ static const XtensaOpcodeOps core_ops[] = {
> .par = (const uint32_t[]){true},
> .op_flags = XTENSA_OP_PRIVILEGED,
> }, {
> + .name = "pfend.a",
> + .translate = translate_nop,
> + }, {
> + .name = "pfend.o",
> + .translate = translate_nop,
> + }, {
> + .name = "pfnxt.f",
> + .translate = translate_nop,
> + }, {
> + .name = "pfwait.a",
> + .translate = translate_nop,
> + }, {
> + .name = "pfwait.o",
> + .translate = translate_nop,
> + }, {
> .name = "pitlb",
> .translate = translate_ptlb,
> .par = (const uint32_t[]){false},
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-05-15 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 20:44 [Qemu-devel] [PATCH 0/9] target/xtensa: implement options for modern cores Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 1/9] target/xtensa: get rid of centralized SR properties Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 2/9] target/xtensa: make internal MMU functions static Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 3/9] target/xtensa: define IDMA and gather/scatter IRQ types Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 4/9] target/xtensa: add parity/ECC option SRs Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 5/9] target/xtensa: implement MPU option Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 6/9] target/xtensa: implement DIWBUI.P opcode Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 7/9] target/xtensa: implement block prefetch option opcodes Max Filippov
2019-05-15 6:46 ` Philippe Mathieu-Daudé [this message]
2019-05-14 20:44 ` [Qemu-devel] [PATCH 8/9] target/xtensa: update list of exception causes Max Filippov
2019-05-14 20:44 ` [Qemu-devel] [PATCH 9/9] target/xtensa: implement exclusive access option Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8293f332-446d-1ff7-7c69-8043568e96de@redhat.com \
--to=philmd@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).