From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e03Uo-0007Rk-1H for qemu-devel@nongnu.org; Thu, 05 Oct 2017 06:35:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e03Uj-0004wJ-1q for qemu-devel@nongnu.org; Thu, 05 Oct 2017 06:35:14 -0400 References: <43071208-759c-6476-0cb0-c4e7e0daaf77@redhat.com> From: Laurent Vivier Message-ID: <82b1a00d-ea31-c76f-96bd-402828cceebf@redhat.com> Date: Thu, 5 Oct 2017 12:35:05 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Add random ioctls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marco A L Barbosa Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org On 05/10/2017 12:24, Marco A L Barbosa wrote: > I doesn't look really trivial... > > To manage the buf field you must read buf_size and it cannot be done in > a generic way: you must define a function to translate the buffer, use > IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL. > > You should send your patch using "git send-email" or "git publish" > instead of adding it in you email client. > > > Thanks for your advices. > > My use case only requires support for RNDGETENTCNT... Considering that > RNDADDENTROPY and RNDGETPOOL are non trivial, would a patch with only > RNDGETENTCNT, RNDADDTOENTCNT, RNDZAPENTCNT and RNDCLEARPOOL be accepted? I think you can only post what you use. If it is tested, it's better... Thanks, Laurent