From: Petr Cvek <petrcvekcz@gmail.com>
To: Samuel Tardieu <samuel.tardieu@telecom-paris.fr>
Cc: pbonzini@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu/timer: Don't use RDTSC on i486
Date: Sun, 26 Nov 2023 23:49:33 +0100 [thread overview]
Message-ID: <82b2394a-a110-4741-b5ec-f4df40e2e827@gmail.com> (raw)
In-Reply-To: <87il5o64yf.fsf@telecom-paris.fr>
Dne 26. 11. 23 v 14:03 Samuel Tardieu napsal(a):
>
> Petr Cvek <petrcvekcz@gmail.com> writes:
>
>> Actually I was thinking about mentioning it in the commit message also, but I wasn't able
>> to find any specification for that (if all compilers use it).
>
> Note that this change would be safe: at worst, some compilers don't use __tune_i386__ and the situation would be the same as today without the patch.
Good remark. You're right.
>
>> Other problem is the __tune_i386__ is also set when -mtune=i386 (but with -march=i686).
>
> Indeed, this is the case for GCC (not clang).
>
> Sam
next prev parent reply other threads:[~2023-11-26 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 12:23 [PATCH] qemu/timer: Don't use RDTSC on i486 Petr Cvek
2023-11-26 12:37 ` Samuel Tardieu
2023-11-26 12:59 ` Petr Cvek
2023-11-26 13:03 ` Samuel Tardieu
2023-11-26 22:49 ` Petr Cvek [this message]
2023-11-26 15:56 ` Paolo Bonzini
2023-11-26 22:52 ` Petr Cvek
2023-11-28 15:52 ` Richard Henderson
2023-11-29 13:50 ` Petr Cvek
2023-11-29 14:27 ` Richard Henderson
2023-11-27 9:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b2394a-a110-4741-b5ec-f4df40e2e827@gmail.com \
--to=petrcvekcz@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.tardieu@telecom-paris.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).