From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87853D12676 for ; Tue, 5 Nov 2024 10:06:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8GSN-0001SD-FM; Tue, 05 Nov 2024 05:06:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8GSL-0001Ry-Ko for qemu-devel@nongnu.org; Tue, 05 Nov 2024 05:06:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8GSJ-0008Su-6s for qemu-devel@nongnu.org; Tue, 05 Nov 2024 05:06:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730801193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XZPvhcuJHfCOWq+j9Md42ETSyHpdcPFaThVvV/LbXzE=; b=cVQt8vKfqVpZ55333je5ZjapmStSZqTGTdmC7yDB5OBK3blKYsbQkklFC4Ux/n2piTYRFQ 8Sbg+slepY6x+Smazuy+61evsXEMHBSe39DaXs1ZrTd+a5AXaBLkr5j2wkVxB+/VIWsuYY R17ouFoCaQpvitSW8dxruIKXAApgYTk= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-rClhvG33NYS3YxqUtaqZHA-1; Tue, 05 Nov 2024 05:06:32 -0500 X-MC-Unique: rClhvG33NYS3YxqUtaqZHA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539eeb63cc3so3355516e87.2 for ; Tue, 05 Nov 2024 02:06:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730801191; x=1731405991; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XZPvhcuJHfCOWq+j9Md42ETSyHpdcPFaThVvV/LbXzE=; b=kZvrU6ggpmjBnN2HRMCc9FSOcUJvoxG0MTbhl3Y9Yt9B34DR+efkkMAPyHl22g/wi/ Q55LYyLAARtlFmeelC9bupl1RMTJvETk0IA1Yh6trVyfoV6aA/RMcdMLqBfNMzSbywlH RSORolEbIsdKT9Vn/0vF/Jfco9q741rk+sS0ZEMY8Xd3LJN7P5EtjtgTppuW/vnv+U1O Gt5XRt7UIfVl28DV639/GKHjz9xYb2WYK7Q5DfU4X08v7Nu9Sc01lJKwq9o6R5m3faCc pUg/Yo02gdPDAhrh+XCxbJxxf1KBnexvtfb+XBxF8nWd9wYkqhNXX8O2P5UbkkcqPPxT 7aig== X-Forwarded-Encrypted: i=1; AJvYcCVc3uturuWPmNgU6Py6zvIz6Jt0vCPMfMfMTMhDt5ILQ0HQ5J+RsoTWqF2V9citoF/5yIdLVeTP43Sj@nongnu.org X-Gm-Message-State: AOJu0YyiGkb7IR7WVKbQs0kJokHbmYGN/Ylsh1Ppy4KXfuRIlMbYFSW5 M4EI0D836FjzKUYrCyH8zPeHem8I+UKfpn3wBjGrdYb6JTNRfLhQJjYZWzzP3e+ChW+lUxdJEc8 maNstzBoBafeVN8h7ow17j9Y1IvJabwA2VzsO6pbWwVOoYQWrgabg X-Received: by 2002:a05:6512:1597:b0:536:54d6:e6d6 with SMTP id 2adb3069b0e04-53b7ecdece7mr11504253e87.17.1730801190530; Tue, 05 Nov 2024 02:06:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbBOWcZ9md7aDTKXWzaypt+PdgsAprKXQDHggukLZ6pVucb+I6yIyWVUgVdzGCVkOZl/i70A== X-Received: by 2002:a05:6512:1597:b0:536:54d6:e6d6 with SMTP id 2adb3069b0e04-53b7ecdece7mr11504222e87.17.1730801190046; Tue, 05 Nov 2024 02:06:30 -0800 (PST) Received: from [192.168.10.3] ([151.49.226.83]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4327d5c65b8sm180496055e9.18.2024.11.05.02.06.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2024 02:06:29 -0800 (PST) Message-ID: <82b74218-f790-4300-ab3b-9c41de1f96b8@redhat.com> Date: Tue, 5 Nov 2024 11:06:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 34/60] i386/tdx: implement tdx_cpu_realizefn() To: Xiaoyao Li , Riku Voipio , Richard Henderson , Zhao Liu , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , Ani Sinha Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Yanan Wang , Cornelia Huck , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eric Blake , Markus Armbruster , Marcelo Tosatti , rick.p.edgecombe@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org References: <20241105062408.3533704-1-xiaoyao.li@intel.com> <20241105062408.3533704-35-xiaoyao.li@intel.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20241105062408.3533704-35-xiaoyao.li@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/5/24 07:23, Xiaoyao Li wrote: > +static void tdx_cpu_realizefn(X86ConfidentialGuest *cg, CPUState *cs, > + Error **errp) > +{ > + X86CPU *cpu = X86_CPU(cs); > + uint32_t host_phys_bits = host_cpu_phys_bits(); > + > + if (!cpu->phys_bits) { > + cpu->phys_bits = host_phys_bits; > + } else if (cpu->phys_bits != host_phys_bits) { > + error_setg(errp, "TDX only supports host physical bits (%u)", > + host_phys_bits); > + } > +} This should be already handled by host_cpu_realizefn(), which is reached via cpu_exec_realizefn(). Why is it needed earlier, but not as early as instance_init? If absolutely needed I would do the assignment in patch 33, but I don't understand why it's necessary. Either way, the check should be in tdx_check_features. Paolo > static int tdx_validate_attributes(TdxGuest *tdx, Error **errp) > { > if ((tdx->attributes & ~tdx_caps->supported_attrs)) { > @@ -733,4 +749,5 @@ static void tdx_guest_class_init(ObjectClass *oc, void *data) > klass->kvm_init = tdx_kvm_init; > x86_klass->kvm_type = tdx_kvm_type; > x86_klass->cpu_instance_init = tdx_cpu_instance_init; > + x86_klass->cpu_realizefn = tdx_cpu_realizefn; > }