Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

[John Snow <jsnow@redhat.com>]

On 4/28/21 5:32 AM, Thomas Huth wrote:
> On 28/04/2021 11.24, Stefan Hajnoczi wrote:
>> On Fri, Apr 16, 2021 at 02:52:56PM +0200, Thomas Huth wrote:
>>> @@ -158,7 +166,11 @@ static void pci_piix_ide_realize(PCIDevice *dev, 
>>> Error **errp)
>>>       vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d);
>>> -    pci_piix_init_ports(d);
>>> +    rc = pci_piix_init_ports(d);
>>> +    if (rc) {
>>> +        error_setg_errno(errp, -rc, "Failed to realize %s",
>>> +                         object_get_typename(OBJECT(dev)));
>>> +    }
>>
>> Is there an error message explaining the reason for the failure
>> somewhere. I can't see one in the patch and imagine users will be
>> puzzled/frustrated by a generic "Failed to realize" error message. Can
>> you make it more meaningful?
> 
> Do you have a suggestion for a better message?
> 
>   Thomas
> 

All of the rest of this thread looks like longer term fixes. I've kept 
this patch staged and will send a PR soonish, after I collate all of the 
other hanging IDE/FDC fixes that are awaiting my attention.

--js