From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] meson: bump submodule to 0.59.3
Date: Thu, 28 Oct 2021 18:05:49 +0200 [thread overview]
Message-ID: <82dda139-9811-7fc8-0dcf-07a7508a7945@redhat.com> (raw)
In-Reply-To: <20211028142826.57327-2-pbonzini@redhat.com>
On 28/10/2021 16.28, Paolo Bonzini wrote:
> This gains some bugfixes, especially:
>
> - it fixes the introspection of array options. While technically we
> still support Meson 0.58.2, this issue only appears when adding a new
> option and not if the user is just building QEMU. In the relatively
> rare case of a contributor using --meson to point to a 0.58 version,
> review can catch spurious changes to scripts/meson-buildoptions.sh
> easily.
>
> - it fixes "meson test" when it is not the process group leader. Make is
> the process group leader when "make check" invokes "meson test", so this
> is a requirement for using it as a test harness.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configure | 2 +-
> meson | 2 +-
> scripts/meson-buildoptions.py | 16 ----------------
> 3 files changed, 2 insertions(+), 18 deletions(-)
Seems to work:
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-10-28 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 14:28 [PATCH 0/2] Replace custom test harness with "meson test" Paolo Bonzini
2021-10-28 14:28 ` [PATCH 1/2] meson: bump submodule to 0.59.3 Paolo Bonzini
2021-10-28 16:05 ` Thomas Huth [this message]
2021-10-28 14:28 ` [PATCH 2/2] build: use "meson test" as the test harness Paolo Bonzini
2021-10-28 18:03 ` Thomas Huth
2021-10-31 21:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82dda139-9811-7fc8-0dcf-07a7508a7945@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).