Re: [PATCH v6 19/42] nvme: enforce valid queue creation sequence

[Maxim Levitsky <mlevitsk@redhat.com>]

On Tue, 2020-03-31 at 07:41 +0200, Klaus Birkelund Jensen wrote:
> On Mar 25 12:43, Maxim Levitsky wrote:
> > On Mon, 2020-03-16 at 07:29 -0700, Klaus Jensen wrote:
> > > From: Klaus Jensen <k.jensen@samsung.com>
> > > 
> > > Support returning Command Sequence Error if Set Features on Number of
> > > Queues is called after queues have been created.
> > > 
> > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> > > ---
> > >  hw/block/nvme.c | 7 +++++++
> > >  hw/block/nvme.h | 1 +
> > >  2 files changed, 8 insertions(+)
> > > 
> > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> > > index 007f8817f101..b40d27cddc46 100644
> > > --- a/hw/block/nvme.c
> > > +++ b/hw/block/nvme.c
> > > @@ -881,6 +881,8 @@ static uint16_t nvme_create_cq(NvmeCtrl *n, NvmeCmd *cmd)
> > >      cq = g_malloc0(sizeof(*cq));
> > >      nvme_init_cq(cq, n, prp1, cqid, vector, qsize + 1,
> > >          NVME_CQ_FLAGS_IEN(qflags));
> > > +
> > > +    n->qs_created = true;
> > 
> > Very minor nitpick, maybe it is worth mentioning in a comment,
> > why this is only needed in CQ creation, as you explained to me.
> > 
> 
> Added.

Thanks a lot!
> 
> > 
> > Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> > 
> > Best regards,
> > 	Maxim Levitsky
> > 
> > 
> > 
> > 
> > 
> 
> 

Best regards,
	Maxim Levitsky