From: "Cédric Le Goater" <clg@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Sergio Lopez" <slp@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Shaoqin Huang" <shahuang@redhat.com>
Subject: Re: [PULL 2/3] vfio: Move the TYPE_* to hw/vfio/types.h
Date: Mon, 21 Jul 2025 08:47:20 +0200 [thread overview]
Message-ID: <82ee6fab-08cc-437f-89fd-428a5d28b448@redhat.com> (raw)
In-Reply-To: <ma53hy32octccy2wnq34hmcshgfyky3xj2rc75gu36rxhxkkoq@hbzm623ss4gc>
On 7/21/25 08:28, Gerd Hoffmann wrote:
> On Fri, Jul 18, 2025 at 11:03:40PM +0200, Cédric Le Goater wrote:
>> On 7/18/25 21:43, Gerd Hoffmann wrote:
>>> From: Shaoqin Huang <shahuang@redhat.com>
>>>
>>> Move the TYPE_* to a new file hw/vfio/types.h because the
>>> TYPE_VFIO_PCI will be used in later patch, but directly include the
>>> hw/vfio/pci.h can cause some compilation error when cross build the
>>> windows version.
>>>
>>> The hw/vfio/types.h can be included to mitigate that problem.
>>
>> As said earlier, the string literal "vfio-pci" could be used instead
>> of the TYPE_VFIO_PCI define and avoid the extra vfio header file.
>
> I think it makes sense to use TYPE_VFIO_PCI, for consistency and to
> avoid typos in the device name.
We should then generalize this practice to all types.
C.
next prev parent reply other threads:[~2025-07-21 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 19:43 [PULL 0/3] Display 20250718 patches Gerd Hoffmann
2025-07-18 19:43 ` [PULL 1/3] ramfb: Add property to control if load the romfile Gerd Hoffmann
2025-07-18 19:43 ` [PULL 2/3] vfio: Move the TYPE_* to hw/vfio/types.h Gerd Hoffmann
2025-07-18 21:03 ` Cédric Le Goater
2025-07-21 6:28 ` Gerd Hoffmann
2025-07-21 6:47 ` Cédric Le Goater [this message]
2025-07-18 19:43 ` [PULL 3/3] hw/i386: Add the ramfb romfile compatibility Gerd Hoffmann
2025-07-28 10:51 ` Thomas Huth
2025-07-28 11:00 ` Cédric Le Goater
2025-07-21 18:31 ` [PULL 0/3] Display 20250718 patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ee6fab-08cc-437f-89fd-428a5d28b448@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shahuang@redhat.com \
--cc=slp@redhat.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).