From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47923)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1e4LEV-0002I5-I0
	for qemu-devel@nongnu.org; Tue, 17 Oct 2017 02:20:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1e4LEP-0006K2-S7
	for qemu-devel@nongnu.org; Tue, 17 Oct 2017 02:20:07 -0400
References: <20171017001209.32276-1-f4bug@amsat.org>
	<20171017001209.32276-36-f4bug@amsat.org>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <82f588d7-b471-be7e-05f5-597e20452a5b@redhat.com>
Date: Tue, 17 Oct 2017 08:19:52 +0200
MIME-Version: 1.0
In-Reply-To: <20171017001209.32276-36-f4bug@amsat.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 35/39] i386/pc: move vmport.c from
 hw/misc/ to hw/i386/
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <f4bug@amsat.org>, Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org


May I suggest to add at least a small patch description a la "It's a
x86-only device, so it does not make sense to keep it in the shared misc
folder" here?

On 17.10.2017 02:12, Philippe Mathieu-Daud=C3=A9 wrote:
> Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
> ---
>  default-configs/i386-softmmu.mak   | 1 -
>  default-configs/x86_64-softmmu.mak | 1 -
>  hw/{misc =3D> i386}/vmport.c         | 0
>  hw/i386/Makefile.objs              | 1 +
>  hw/misc/Makefile.objs              | 2 --
>  5 files changed, 1 insertion(+), 4 deletions(-)
>  rename hw/{misc =3D> i386}/vmport.c (100%)
>=20
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-so=
ftmmu.mak
> index d2ab2f6655..dbc4e65652 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -41,7 +41,6 @@ CONFIG_PCI_PIIX=3Dy
>  CONFIG_WDT_IB700=3Dy
>  CONFIG_ISA_DEBUG=3Dy
>  CONFIG_ISA_TESTDEV=3Dy
> -CONFIG_VMPORT=3Dy
>  CONFIG_SGA=3Dy
>  CONFIG_LPC_ICH9=3Dy
>  CONFIG_PCI_Q35=3Dy
> diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_6=
4-softmmu.mak
> index 9bde2f1c4b..f1fe508ff4 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -41,7 +41,6 @@ CONFIG_PCI_PIIX=3Dy
>  CONFIG_WDT_IB700=3Dy
>  CONFIG_ISA_DEBUG=3Dy
>  CONFIG_ISA_TESTDEV=3Dy
> -CONFIG_VMPORT=3Dy
>  CONFIG_SGA=3Dy
>  CONFIG_LPC_ICH9=3Dy
>  CONFIG_PCI_Q35=3Dy
> diff --git a/hw/misc/vmport.c b/hw/i386/vmport.c
> similarity index 100%
> rename from hw/misc/vmport.c
> rename to hw/i386/vmport.c
> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> index 909ead6a77..feff56a9b7 100644
> --- a/hw/i386/Makefile.objs
> +++ b/hw/i386/Makefile.objs
> @@ -9,3 +9,4 @@ obj-$(CONFIG_XEN) +=3D ../xenpv/ xen/
>  obj-y +=3D kvmvapic.o
>  obj-y +=3D acpi-build.o
>  obj-y +=3D pci-assign-load-rom.o
> +obj-y +=3D vmport.o

It seems to be possible to disable this device in the configuration
(when also disabling VMMOUSE), so I'd maybe be nicer to rather keep the
config switch, I think (in case people want to build a minimalistic QEMU)

 Thomas