From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] hw/display/sm501: Remove unneeded increment from loop
Date: Wed, 5 Apr 2023 18:31:42 +0200 [thread overview]
Message-ID: <82fb447f-f9b2-cc08-5be2-e5673f59fe14@linaro.org> (raw)
In-Reply-To: <20230405161234.6EF0A74633D@zero.eik.bme.hu>
On 5/4/23 17:57, BALATON Zoltan wrote:
> As Coverity points out (CID 1508621) the calculation to increment i in
> the fill fallback loop is ineffective as it is overwritten in next
> statement. This was left there by mistake from a previous version but
> is not needed in the current approach so remove the superfluous
> increment statement.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-04-05 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 15:57 [PATCH] hw/display/sm501: Remove unneeded increment from loop BALATON Zoltan
2023-04-05 16:31 ` Philippe Mathieu-Daudé [this message]
2023-04-13 21:26 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82fb447f-f9b2-cc08-5be2-e5673f59fe14@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).