From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB735C43331 for ; Sat, 4 Apr 2020 00:34:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A50192063A for ; Sat, 4 Apr 2020 00:34:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="alzfZHz0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A50192063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKWlN-0003zb-Sn for qemu-devel@archiver.kernel.org; Fri, 03 Apr 2020 20:34:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48592) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKWko-0003Yc-4F for qemu-devel@nongnu.org; Fri, 03 Apr 2020 20:33:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKWkm-000197-U5 for qemu-devel@nongnu.org; Fri, 03 Apr 2020 20:33:41 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:34113) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKWkm-00018G-56 for qemu-devel@nongnu.org; Fri, 03 Apr 2020 20:33:40 -0400 Received: by mail-pl1-x644.google.com with SMTP id a23so3478562plm.1 for ; Fri, 03 Apr 2020 17:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Vi1xtTN7UB/twtE/RhBtS602Oa6rQh70/R8B+HG/Bcc=; b=alzfZHz0JnwQOz/5ZyXdyI2WKkQ8nUD4s3yAKFilq/XwkCr40SV9QnKO0kjeDP682L EJZ4MMV5L1oyPuMLqS9lp8iWpxSbtifv/WwjEbWeVGRYjVnFuVReENpT5kizm94BWkRe IDwu0GqOieCXjI/rd/jQw60VzU5VqwTrkhLfa+T2ryJycXiVZtSUJHLeGxHLnZGKk8QC sqlYA+PJKm46K/OQQ0Sup0W7SYjXecK3iJH6bv6sey8qZ+8kEG2FbKHHuEjRqv2xZzOx sutp5pzmdHIKcnGDrLOPnxtC8uyaV0bbZyvaLiLjAU178Je+MMadKp2tPUBEjsEU/R+K j49Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vi1xtTN7UB/twtE/RhBtS602Oa6rQh70/R8B+HG/Bcc=; b=i164QY021o9kAXxZinvgA6niyv/lIbOYfhgOEfb/8CDZrW+bJsTcFknLCMhtA0nzQd DI0Fk85JslCFDjpCEZABTeln8vX93KSX4er48Wk0i/75cjamJqrmFZGkdwmVoePfnaOS KMeN5pBbd6/fLj5zc5cDq64zCx/V4cjAGl/QNyeu6az8b+D6kO+gAwmDAMOmF4/rOW73 rr0Lejbm8BjKS1V5BjGjNfRlcSvkga55cc6X7XFUiAalYPzjZCxbBWV5kFRqR+AsqK0Q hvwoKQT+M1ljh9K6Ly/RVBtc8sSoTflTOg2J0pKCOpe/vEzPOJwf7u435eZ5MquQED7n BAcQ== X-Gm-Message-State: AGi0PuavjudiFbFR8IV2o2gLL1i/oBJ1i3756xHmkDTjtoq9TQ9qO2nO hymFXQow00QnpSmmOFc8izdtcQ== X-Google-Smtp-Source: APiQypJz0Y8aeTfu7V0ZamS3keWuP3q5Ca/3nreezZGAYBOZZjcM1pywjeg9lg9Bwn5Epmdnxuo4/w== X-Received: by 2002:a17:902:9004:: with SMTP id a4mr9459878plp.275.1585960418891; Fri, 03 Apr 2020 17:33:38 -0700 (PDT) Received: from [192.168.1.11] (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id r189sm6108869pgr.31.2020.04.03.17.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 17:33:38 -0700 (PDT) Subject: Re: [PATCH v3 08/12] linux-user: factor out reading of /proc/self/maps To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20200403191150.863-1-alex.bennee@linaro.org> <20200403191150.863-9-alex.bennee@linaro.org> From: Richard Henderson Message-ID: <830061f9-91cd-145c-4388-f2bfe9a3d7a6@linaro.org> Date: Fri, 3 Apr 2020 17:33:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200403191150.863-9-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::644 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/3/20 12:11 PM, Alex Bennée wrote: > + e->is_read = fields[1][0] == 'r' ? true : false; > + e->is_write = fields[1][1] == 'w' ? true : false; > + e->is_exec = fields[1][2] == 'x' ? true : false; > + e->is_priv = fields[1][3] == 'p' ? true : false; Drop the redundant ? true : false. That is of course the result of the boolean operation. > + errors += qemu_strtoi(fields[4], NULL, 10, &e->inode); The root of the typedef chain for ino_t is /usr/include/asm-generic/posix_types.h:typedef __kernel_ulong_t __kernel_ino_t; so I think you should just go ahead and use unsigned long here too. Or maybe even uint64_t, because 32-bit has ino64_t, and could in fact have a Large Number here. r~