From: Helge Deller <deller@gmx.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: Fix pipe() vs. pipe2() usage for ALPHA, MIPS, SH4 and SPARC
Date: Mon, 18 Jul 2022 18:25:39 +0200 [thread overview]
Message-ID: <830ee712-dce7-d054-282e-d6c0c3911ac8@gmx.de> (raw)
In-Reply-To: <CAFEAcA_2w+T_cg3ctNnS5i-gZgU3OwGCRX5pvH3AXUsStDOvtw@mail.gmail.com>
On 7/18/22 18:17, Peter Maydell wrote:
> On Mon, 18 Jul 2022 at 16:50, Helge Deller <deller@gmx.de> wrote:
>> On 7/18/22 16:33, Peter Maydell wrote:
>>> So my preference would be that we should just say "we can assume
>>> that pipe2 is always available and implemented on linux hosts" and
>>> remove the code that handles the possibility that it isn't.
>>
>> Ok for me.
>> Do you want me to send a patch or will you do?
>
> If you'd like to write the patch that would be great.
> You can remove the meson.build line that sets CONFIG_PIPE2
> as well, since we have no other places that check it.
Ok, I'll do.
Btw, you asked:
> Did you run into this in practice, or is it just a
> theoretical concern ?
I didn't faced the problem in practice. I'm trying to solve another
issue and while debugging I stumbled over that code.
Helge
prev parent reply other threads:[~2022-07-18 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 16:08 [PATCH] linux-user: Fix pipe() vs. pipe2() usage for ALPHA, MIPS, SH4 and SPARC Helge Deller
2022-07-17 16:37 ` Helge Deller
2022-07-18 12:51 ` Peter Maydell
2022-07-18 14:21 ` Helge Deller
2022-07-18 14:33 ` Peter Maydell
2022-07-18 15:49 ` Helge Deller
2022-07-18 16:17 ` Peter Maydell
2022-07-18 16:25 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=830ee712-dce7-d054-282e-d6c0c3911ac8@gmx.de \
--to=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).