From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D70C433B4 for ; Fri, 30 Apr 2021 05:48:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B94161400 for ; Fri, 30 Apr 2021 05:48:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B94161400 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcM0r-0005A3-7y for qemu-devel@archiver.kernel.org; Fri, 30 Apr 2021 01:48:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcM0B-0004it-V3 for qemu-devel@nongnu.org; Fri, 30 Apr 2021 01:47:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcM07-00022Y-Cp for qemu-devel@nongnu.org; Fri, 30 Apr 2021 01:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619761661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zqYHN1mBgEhaZ9tBX7QXYCtH9UG+UdBUWk4SfwWJhKg=; b=fsOK2izY7z4KjWaoYEYRMoReEL6I7+eJy7nSLegIL3ymwaRhYpG5TMy87ivZjK+A7tQ03Y n6xpTPci7/6MbrIf82lVBR1IaUfQbSIKqKgu7BOakU0H1VlzVlqxXfVLpS6H4CXFaUKdov Osw7BnQ3YwL7v3oBkoJnooR+MxgeH4s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-435-JZVe1iwgNxC6SPbS4bqlUQ-1; Fri, 30 Apr 2021 01:47:37 -0400 X-MC-Unique: JZVe1iwgNxC6SPbS4bqlUQ-1 Received: by mail-wr1-f69.google.com with SMTP id a12-20020a5d6cac0000b0290109c3c8d66fso8919147wra.15 for ; Thu, 29 Apr 2021 22:47:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zqYHN1mBgEhaZ9tBX7QXYCtH9UG+UdBUWk4SfwWJhKg=; b=Smw+Sn6fXmVBFke1muEosGaYKPtyNrmLvLKEq2bNuqkuKSO9jt6BF+CimhHU8bTjGj E0rnSa/Z0GtARB8qQid512mi7YBeYerTYnyHF3QsWGkUkmmkhp8dXgXMjhD2JB7M7XfW OCyv6OYOnprKoQKkWQ6pdpIE/IaS9JCqli+joL9oTCFPUDtmEoEKU0wkvZp80+04pY3M 3yQAJUhzESU7z2YXb0raHjhaj9+YklXJY587VvSf+x1ZdrZWBRic1ThJH3jKCJ8fxgH8 nZw8K5pvV2Vc3iUW92aUUgDSNSQ+giwB+9g/NvxPxQkf1SLSEwY+JghVWTfwntUfYRGD SvvQ== X-Gm-Message-State: AOAM532pWr5pP1UOMHS+NbOwOnHj3bH6SbHegADAuQH3kfzIYWAt7fKH lTFDf5EGLm47czW76Q+tSUzHy4gv6wxIFgQFJAf2HMmepGgdbZSlAlB0qMKHQw0J/fdUteTUBLy yvr01K9HQL6yIPHo= X-Received: by 2002:a7b:c097:: with SMTP id r23mr4078008wmh.40.1619761655946; Thu, 29 Apr 2021 22:47:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJuZ6413VSK0f/udIvm+4a1EEHaYDdbptGMHYC83JSVLdrpNVPtTc83gqGgnxgd/mnuG7BVA== X-Received: by 2002:a7b:c097:: with SMTP id r23mr4077984wmh.40.1619761655693; Thu, 29 Apr 2021 22:47:35 -0700 (PDT) Received: from ?IPv6:2a02:ab04:2f42:3c00:e5c2:1c68:9939:9520? (2a02-ab04-2f42-3c00-e5c2-1c68-9939-9520.dynamic.v6.chello.sk. [2a02:ab04:2f42:3c00:e5c2:1c68:9939:9520]) by smtp.gmail.com with ESMTPSA id l25sm2111728wmi.17.2021.04.29.22.47.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 22:47:35 -0700 (PDT) Subject: Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property To: Stefan Hajnoczi , qemu-devel@nongnu.org References: <20210429155221.1226561-1-stefanha@redhat.com> From: =?UTF-8?B?TWljaGFsIFByw612b3puw61r?= Message-ID: <83108055-6db0-9c03-1a91-ab940f816cfe@redhat.com> Date: Fri, 30 Apr 2021 07:47:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210429155221.1226561-1-stefanha@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mprivozn@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=mprivozn@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.22, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Krempa , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , libvir-list@redhat.com, "Dr . David Alan Gilbert" , Max Reitz , Christoph Hellwig Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/29/21 5:52 PM, Stefan Hajnoczi wrote: > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > completely at this point. > > Drop the scsi=on|off option. It was only available on Legacy virtio-blk > devices. Linux v5.6 already dropped support for it. > > Remove the hw_compat_2_4[] property assignment since scsi=on|off no > longer exists. Old guests with Legacy virtio-blk devices no longer see > the SCSI host features bit. > > Live migrating old guests from an old QEMU with the SCSI feature bit > enabled will fail with "Features 0x... unsupported. Allowed features: > 0x...". We've followed the QEMU deprecation policy so users have been > warned... > > I have tested that libvirt still works when the property is absent. It > no longer adds scsi=on|off to the command-line. > > Cc: Markus Armbruster > Cc: Christoph Hellwig > Cc: Peter Krempa > Cc: Dr. David Alan Gilbert > Signed-off-by: Stefan Hajnoczi > --- > docs/specs/tpm.rst | 2 +- > docs/system/deprecated.rst | 13 --- > docs/pci_expander_bridge.txt | 2 +- > hw/block/virtio-blk.c | 192 +---------------------------------- > hw/core/machine.c | 2 - > 5 files changed, 3 insertions(+), 208 deletions(-) Reviewed-by: Michal Privoznik Michal