* [PATCH] util: Return void on iova_tree_remove
@ 2022-04-27 15:49 Eugenio Pérez
2022-05-12 15:48 ` Eugenio Perez Martin
2022-06-28 8:57 ` Laurent Vivier
0 siblings, 2 replies; 8+ messages in thread
From: Eugenio Pérez @ 2022-04-27 15:49 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, lvivier, Jason Wang, Peter Xu
It always returns IOVA_OK so nobody uses it.
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
include/qemu/iova-tree.h | 4 +---
util/iova-tree.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
index c938fb0793..16bbfdf5f8 100644
--- a/include/qemu/iova-tree.h
+++ b/include/qemu/iova-tree.h
@@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
* provided. The range does not need to be exactly what has inserted,
* all the mappings that are included in the provided range will be
* removed from the tree. Here map->translated_addr is meaningless.
- *
- * Return: 0 if succeeded, or <0 if error.
*/
-int iova_tree_remove(IOVATree *tree, const DMAMap *map);
+void iova_tree_remove(IOVATree *tree, const DMAMap *map);
/**
* iova_tree_find:
diff --git a/util/iova-tree.c b/util/iova-tree.c
index 6dff29c1f6..fee530a579 100644
--- a/util/iova-tree.c
+++ b/util/iova-tree.c
@@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator)
g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
}
-int iova_tree_remove(IOVATree *tree, const DMAMap *map)
+void iova_tree_remove(IOVATree *tree, const DMAMap *map)
{
const DMAMap *overlap;
while ((overlap = iova_tree_find(tree, map))) {
g_tree_remove(tree->tree, overlap);
}
-
- return IOVA_OK;
}
/**
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] util: Return void on iova_tree_remove
2022-04-27 15:49 [PATCH] util: Return void on iova_tree_remove Eugenio Pérez
@ 2022-05-12 15:48 ` Eugenio Perez Martin
2022-05-12 16:03 ` Peter Xu
2022-06-28 8:57 ` Laurent Vivier
1 sibling, 1 reply; 8+ messages in thread
From: Eugenio Perez Martin @ 2022-05-12 15:48 UTC (permalink / raw)
To: qemu-level; +Cc: qemu-trivial, Laurent Vivier, Jason Wang, Peter Xu
On Wed, Apr 27, 2022 at 5:50 PM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> It always returns IOVA_OK so nobody uses it.
>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Hi! Friendly ping about this, is it something pending from my side?
Thanks!
> ---
> include/qemu/iova-tree.h | 4 +---
> util/iova-tree.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
> index c938fb0793..16bbfdf5f8 100644
> --- a/include/qemu/iova-tree.h
> +++ b/include/qemu/iova-tree.h
> @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
> * provided. The range does not need to be exactly what has inserted,
> * all the mappings that are included in the provided range will be
> * removed from the tree. Here map->translated_addr is meaningless.
> - *
> - * Return: 0 if succeeded, or <0 if error.
> */
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map);
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map);
>
> /**
> * iova_tree_find:
> diff --git a/util/iova-tree.c b/util/iova-tree.c
> index 6dff29c1f6..fee530a579 100644
> --- a/util/iova-tree.c
> +++ b/util/iova-tree.c
> @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator)
> g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
> }
>
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map)
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map)
> {
> const DMAMap *overlap;
>
> while ((overlap = iova_tree_find(tree, map))) {
> g_tree_remove(tree->tree, overlap);
> }
> -
> - return IOVA_OK;
> }
>
> /**
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] util: Return void on iova_tree_remove
2022-05-12 15:48 ` Eugenio Perez Martin
@ 2022-05-12 16:03 ` Peter Xu
2022-05-12 16:53 ` Laurent Vivier
0 siblings, 1 reply; 8+ messages in thread
From: Peter Xu @ 2022-05-12 16:03 UTC (permalink / raw)
To: Eugenio Perez Martin
Cc: qemu-level, qemu-trivial, Laurent Vivier, Jason Wang,
Michael S. Tsirkin
On Thu, May 12, 2022 at 05:48:47PM +0200, Eugenio Perez Martin wrote:
> On Wed, Apr 27, 2022 at 5:50 PM Eugenio Pérez <eperezma@redhat.com> wrote:
> >
> > It always returns IOVA_OK so nobody uses it.
> >
> > Acked-by: Jason Wang <jasowang@redhat.com>
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>
> Hi! Friendly ping about this, is it something pending from my side?
Don't think so. :)
This patch does look fine to go via trivial branch, Laurent?
Also copying Michael since for other iova-tree change it always go via
Michael before.
Thanks,
--
Peter Xu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] util: Return void on iova_tree_remove
2022-05-12 16:03 ` Peter Xu
@ 2022-05-12 16:53 ` Laurent Vivier
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2022-05-12 16:53 UTC (permalink / raw)
To: Peter Xu, Eugenio Perez Martin
Cc: qemu-level, qemu-trivial, Jason Wang, Michael S. Tsirkin
On 12/05/2022 18:03, Peter Xu wrote:
> On Thu, May 12, 2022 at 05:48:47PM +0200, Eugenio Perez Martin wrote:
>> On Wed, Apr 27, 2022 at 5:50 PM Eugenio Pérez <eperezma@redhat.com> wrote:
>>>
>>> It always returns IOVA_OK so nobody uses it.
>>>
>>> Acked-by: Jason Wang <jasowang@redhat.com>
>>> Reviewed-by: Peter Xu <peterx@redhat.com>
>>> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>>
>> Hi! Friendly ping about this, is it something pending from my side?
>
> Don't think so. :)
>
> This patch does look fine to go via trivial branch, Laurent?
>
> Also copying Michael since for other iova-tree change it always go via
> Michael before.
>
I can take it via qemu-trivial.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] util: Return void on iova_tree_remove
2022-04-27 15:49 [PATCH] util: Return void on iova_tree_remove Eugenio Pérez
2022-05-12 15:48 ` Eugenio Perez Martin
@ 2022-06-28 8:57 ` Laurent Vivier
1 sibling, 0 replies; 8+ messages in thread
From: Laurent Vivier @ 2022-06-28 8:57 UTC (permalink / raw)
To: Eugenio Pérez, qemu-devel
Cc: qemu-trivial, lvivier, Jason Wang, Peter Xu
Le 27/04/2022 à 17:49, Eugenio Pérez a écrit :
> It always returns IOVA_OK so nobody uses it.
>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> include/qemu/iova-tree.h | 4 +---
> util/iova-tree.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
> index c938fb0793..16bbfdf5f8 100644
> --- a/include/qemu/iova-tree.h
> +++ b/include/qemu/iova-tree.h
> @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
> * provided. The range does not need to be exactly what has inserted,
> * all the mappings that are included in the provided range will be
> * removed from the tree. Here map->translated_addr is meaningless.
> - *
> - * Return: 0 if succeeded, or <0 if error.
> */
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map);
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map);
>
> /**
> * iova_tree_find:
> diff --git a/util/iova-tree.c b/util/iova-tree.c
> index 6dff29c1f6..fee530a579 100644
> --- a/util/iova-tree.c
> +++ b/util/iova-tree.c
> @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator)
> g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
> }
>
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map)
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map)
> {
> const DMAMap *overlap;
>
> while ((overlap = iova_tree_find(tree, map))) {
> g_tree_remove(tree->tree, overlap);
> }
> -
> - return IOVA_OK;
> }
>
> /**
> --
> 2.27.0
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] util: Return void on iova_tree_remove
@ 2022-03-31 18:17 Eugenio Pérez
2022-03-31 18:30 ` Peter Xu
2022-04-01 2:30 ` Jason Wang
0 siblings, 2 replies; 8+ messages in thread
From: Eugenio Pérez @ 2022-03-31 18:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Jason Wang, Peter Xu
It always returns IOVA_OK so nobody uses it.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
include/qemu/iova-tree.h | 4 +---
util/iova-tree.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
index c938fb0793..16bbfdf5f8 100644
--- a/include/qemu/iova-tree.h
+++ b/include/qemu/iova-tree.h
@@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
* provided. The range does not need to be exactly what has inserted,
* all the mappings that are included in the provided range will be
* removed from the tree. Here map->translated_addr is meaningless.
- *
- * Return: 0 if succeeded, or <0 if error.
*/
-int iova_tree_remove(IOVATree *tree, const DMAMap *map);
+void iova_tree_remove(IOVATree *tree, const DMAMap *map);
/**
* iova_tree_find:
diff --git a/util/iova-tree.c b/util/iova-tree.c
index 6dff29c1f6..fee530a579 100644
--- a/util/iova-tree.c
+++ b/util/iova-tree.c
@@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator)
g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
}
-int iova_tree_remove(IOVATree *tree, const DMAMap *map)
+void iova_tree_remove(IOVATree *tree, const DMAMap *map)
{
const DMAMap *overlap;
while ((overlap = iova_tree_find(tree, map))) {
g_tree_remove(tree->tree, overlap);
}
-
- return IOVA_OK;
}
/**
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] util: Return void on iova_tree_remove
2022-03-31 18:17 Eugenio Pérez
@ 2022-03-31 18:30 ` Peter Xu
2022-04-01 2:30 ` Jason Wang
1 sibling, 0 replies; 8+ messages in thread
From: Peter Xu @ 2022-03-31 18:30 UTC (permalink / raw)
To: Eugenio Pérez; +Cc: qemu-trivial, Jason Wang, qemu-devel
On Thu, Mar 31, 2022 at 08:17:12PM +0200, Eugenio Pérez wrote:
> It always returns IOVA_OK so nobody uses it.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] util: Return void on iova_tree_remove
2022-03-31 18:17 Eugenio Pérez
2022-03-31 18:30 ` Peter Xu
@ 2022-04-01 2:30 ` Jason Wang
1 sibling, 0 replies; 8+ messages in thread
From: Jason Wang @ 2022-04-01 2:30 UTC (permalink / raw)
To: Eugenio Pérez; +Cc: qemu-trivial, qemu-devel, Peter Xu
On Fri, Apr 1, 2022 at 2:17 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> It always returns IOVA_OK so nobody uses it.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> include/qemu/iova-tree.h | 4 +---
> util/iova-tree.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
> index c938fb0793..16bbfdf5f8 100644
> --- a/include/qemu/iova-tree.h
> +++ b/include/qemu/iova-tree.h
> @@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
> * provided. The range does not need to be exactly what has inserted,
> * all the mappings that are included in the provided range will be
> * removed from the tree. Here map->translated_addr is meaningless.
> - *
> - * Return: 0 if succeeded, or <0 if error.
> */
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map);
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map);
>
> /**
> * iova_tree_find:
> diff --git a/util/iova-tree.c b/util/iova-tree.c
> index 6dff29c1f6..fee530a579 100644
> --- a/util/iova-tree.c
> +++ b/util/iova-tree.c
> @@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator)
> g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
> }
>
> -int iova_tree_remove(IOVATree *tree, const DMAMap *map)
> +void iova_tree_remove(IOVATree *tree, const DMAMap *map)
> {
> const DMAMap *overlap;
>
> while ((overlap = iova_tree_find(tree, map))) {
> g_tree_remove(tree->tree, overlap);
> }
> -
> - return IOVA_OK;
> }
>
> /**
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-06-28 9:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-27 15:49 [PATCH] util: Return void on iova_tree_remove Eugenio Pérez
2022-05-12 15:48 ` Eugenio Perez Martin
2022-05-12 16:03 ` Peter Xu
2022-05-12 16:53 ` Laurent Vivier
2022-06-28 8:57 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 18:17 Eugenio Pérez
2022-03-31 18:30 ` Peter Xu
2022-04-01 2:30 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).