From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3OQl-0001nF-2F for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3OQk-0000dA-3a for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:37:54 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:50364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3OQj-0000d6-SB for qemu-devel@nongnu.org; Mon, 20 Aug 2012 05:37:54 -0400 Date: Mon, 20 Aug 2012 05:37:52 -0400 (EDT) From: Alon Levy Message-ID: <831210740.16567798.1345455472749.JavaMail.root@redhat.com> In-Reply-To: <5031FD38.3050608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org ----- Original Message ----- > Hi, > > >> Maybe revisit upstream spice packaging? spice internal usage of > >> spice-protocol is handled via submodules now. Are there external > >> users, other than qemu? Does it make sense to keep the > >> spice-server / spice-protocol split in the first place? Or should > >> spice-server just provide the protocol headers too? > > > > spice-server is a much larger project then spice-protocol. The > > agents > > and the drivers don't need any bits in spice-server. > > I didn't meant to kill the spice-protocol git repo, just the way it > is > distributed. > > Remove any makefiles & stuff from spice-protocol, so it is really > just > the headers. Any spice-internal users get it as submodule like they > do > today. spice-server gets updated to also install the spice-protocol > header files from the submodule. > > Kills the whole protocol header version dance for the external users > (the submodule usage already does it for the internal ones). When > you've installed spice-server-devel you automatically also have > recent > enougth spice protocol headers installed. > Yes, we could do it, I'm not sure it's worth the trouble. The only benefit is that it removes one more pkg-config check. But it means that anyone who wants to develop a new client has to install spice-server to get the client headers. Right now the protocol has other problems - it doesn't contain the complete protocol specification, spice.proto, that is actually in spice-common. And it's wrongly named - it contains the agent protocol and the device "protocol" as well. > > Sure, we can > > unify them - it would make it easier for qemu and Xspice (the only > > other external user). > > So both external users need the spice server too. So I think it > makes > sense to have spice-server ship the protocol headers. > > cheers, > Gerd > > >