Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

On 09/01/2017 03:10 PM, Brian Steffens wrote:
> This adds a boolean option called 'shared' to block devices. It defaults
> to off/false. When enabled for a particular block device, the 'shared' option
> causes the block migration code to skip over syncing of that device. This
> allows controlling exactly which block devices get synced during a migration.
> 
> Signed-off-by: Brian Steffens <briansteffens@gmail.com>
> ---
>  block.c                   | 7 +++++++
>  block/qapi.c              | 2 ++
>  include/block/block.h     | 1 +
>  include/block/block_int.h | 3 +++
>  migration/block.c         | 4 ++++
>  qapi/block-core.json      | 2 +-
>  6 files changed, 18 insertions(+), 1 deletion(-)
> 

> +++ b/qapi/block-core.json
> @@ -365,7 +365,7 @@
>              '*bps_wr_max_length': 'int', '*iops_max_length': 'int',
>              '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',
>              '*iops_size': 'int', '*group': 'str', 'cache': 'BlockdevCacheInfo',
> -            'write_threshold': 'int' } }
> +            'write_threshold': 'int', 'shared': 'bool' } }

Missing documentation, which should include '(since 2.11)'.  The new
parameter should be optional on input; but it looks like you've only
modified a structure that is present on output - so you're missing a
QAPI edit that mirrors the command-line edit.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]