From: Stefan Berger <stefanb@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
qemu-trivial@nongnu.org,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Corey Minyard" <minyard@acm.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
qemu-ppc@nongnu.org, "Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition
Date: Tue, 13 Oct 2020 10:23:42 -0400 [thread overview]
Message-ID: <8333bb93-f4b6-dbe6-daa7-288d71b272bc@linux.ibm.com> (raw)
In-Reply-To: <70253a5e-d4cc-fb89-6235-cd53ee1bc18b@amsat.org>
On 10/13/20 4:26 AM, Philippe Mathieu-Daudé wrote:
> On 10/13/20 9:20 AM, Gerd Hoffmann wrote:
>> On Sun, Oct 11, 2020 at 09:32:23PM +0200, Philippe
>> Mathieu-Daudé wrote:
>>> The TPM TIS device uses IRQ #5 by default. Add this
>>> default definition to the IsaIrqNumber enum.
>>
>> IRQ 5 has no fixed assignment. All kinds of add-on isa cards (sound,
>> net) used to use irq #5 by default because that one wasn't assigned
>> otherwise. Seems these days tpm and ipmi use it ...
>
> Yes, I'll drop this patch.
I think this patch is good but maybe the name should be a different one.
Rather than having these numbers in the code you could maybe call it
something like this here, which makes grepping through the code a bit
easier:
ISA_IRQ_IRQ5 = 5,
Regards,
Stefan
>
> Thanks,
>
> Phil.
next prev parent reply other threads:[~2020-10-13 14:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 19:32 [PATCH 00/10] hw/isa: Introduce definitions for default IRQ values Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 01/10] hw/isa: Introduce IsaIrqNumber enum Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 02/10] hw/isa: Add the ISA_IRQ_KBD_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 03/10] hw/isa: Add the ISA_IRQ_SER_DEFAULT definition Philippe Mathieu-Daudé
2020-10-13 7:14 ` Gerd Hoffmann
2020-10-11 19:32 ` [PATCH 04/10] hw/isa: Add the ISA_IRQ_TPM_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 20:28 ` Stefan Berger
2020-10-11 21:07 ` Philippe Mathieu-Daudé
2020-10-13 7:20 ` Gerd Hoffmann
2020-10-13 8:26 ` Philippe Mathieu-Daudé
2020-10-13 14:23 ` Stefan Berger [this message]
2020-10-11 19:32 ` [PATCH 05/10] hw/isa: Add the ISA_IRQ_FDC_DEFAULT definition Philippe Mathieu-Daudé
2020-10-12 14:17 ` John Snow
2020-10-11 19:32 ` [PATCH 06/10] hw/isa: Add the ISA_IRQ_PAR_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 07/10] hw/isa: Add the ISA_IRQ_RTC_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 08/10] hw/isa: Add the ISA_IRQ_NET_DEFAULT definition Philippe Mathieu-Daudé
2020-10-13 7:23 ` Gerd Hoffmann
2020-10-13 8:27 ` Philippe Mathieu-Daudé
2020-10-13 14:20 ` Stefan Berger
2020-10-11 19:32 ` [PATCH 09/10] hw/isa: Add the ISA_IRQ_MOU_DEFAULT definition Philippe Mathieu-Daudé
2020-10-11 19:32 ` [PATCH 10/10] hw/isa: Add the ISA_IRQ_IDE_DEFAULT definition Philippe Mathieu-Daudé
2020-10-12 14:16 ` John Snow
2020-10-13 7:25 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8333bb93-f4b6-dbe6-daa7-288d71b272bc@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=minyard@acm.org \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).