qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: "Stefan Weil" <sw@weilnetz.de>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v2 2/9] tests: fix test-io-channel-command on win32
Date: Mon, 6 Feb 2023 09:13:31 +0100	[thread overview]
Message-ID: <83359feb-bcfa-31d7-e116-36f509a7abe2@linaro.org> (raw)
In-Reply-To: <20230129182414.583349-3-marcandre.lureau@redhat.com>

On 29/1/23 19:24, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> socat "PIPE:"" on Windows are named pipes, not fifo path names.
> 
> Fixes: commit 68406d10859 ("tests/unit: cleanups for test-io-channel-command")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   tests/unit/test-io-channel-command.c | 6 ++++++
>   1 file changed, 6 insertions(+)

This doesn't apply cleanly on top of c906e6fbaa ("tests/unit: drop hacky
race avoidance in test-io-channel-command").



  parent reply	other threads:[~2023-02-06  8:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 18:24 [PATCH v2 0/9] Various win32 fixes & teach 'getfd' QMP command to import sockets marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 1/9] tests: fix path separator, use g_build_filename() marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 2/9] tests: fix test-io-channel-command on win32 marcandre.lureau
2023-02-06  8:09   ` Thomas Huth
2023-02-07 12:55     ` Marc-André Lureau
2023-02-06  8:13   ` Philippe Mathieu-Daudé [this message]
2023-01-29 18:24 ` [PATCH v2 3/9] tests/docker: fix a win32 error due to portability marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 4/9] osdep: implement qemu_socketpair() for win32 marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 5/9] qmp: 'add_client' actually expects sockets marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 6/9] qapi: implement conditional command arguments marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 7/9] qmp: teach 'getfd' to import sockets on win32 marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 8/9] libqtest: make qtest_qmp_add_client work " marcandre.lureau
2023-01-29 18:24 ` [PATCH v2 9/9] qtest: enable vnc-display test " marcandre.lureau
2023-02-06  6:36 ` [PATCH v2 0/9] Various win32 fixes & teach 'getfd' QMP command to import sockets Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83359feb-bcfa-31d7-e116-36f509a7abe2@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).