qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Jason Thorpe <thorpej@me.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] alpha: Provide a PCI-ISA bridge device node for guest OS's that expect it
Date: Mon, 14 Jun 2021 21:20:21 -0700	[thread overview]
Message-ID: <8346c497-f432-0d75-bc60-0fcceed3420f@linaro.org> (raw)
In-Reply-To: <20210613211549.18094-4-thorpej@me.com>

On 6/13/21 2:15 PM, Jason Thorpe wrote:
> +/* The following was copied from hw/isa/i82378.c and modified to provide
> +   only the minimal PCI device node.  */
> +
> +/*
> + * QEMU Intel i82378 emulation (PCI to ISA bridge)
> + *

Why can't we just use the existing device model?
Certainly duplicating code like this isn't the best way.


r~


  reply	other threads:[~2021-06-15  4:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13 21:15 [PATCH 0/4] Emulator fixes to enable running NetBSD/alpha Jason Thorpe
2021-06-13 21:15 ` [PATCH 1/4] mc146818rtc: Make PF independent of PIE Jason Thorpe
2021-06-15  4:17   ` Richard Henderson
2021-06-16 17:34     ` Jason Thorpe
2021-06-19 15:56       ` Philippe Mathieu-Daudé
2021-06-19 16:25         ` Jason Thorpe
2021-06-13 21:15 ` [PATCH 2/4] alpha: Set minimum PCI device ID to 1 to match Clipper IRQ mappings Jason Thorpe
2021-06-15  4:03   ` Richard Henderson
2021-06-13 21:15 ` [PATCH 3/4] alpha: Provide a PCI-ISA bridge device node for guest OS's that expect it Jason Thorpe
2021-06-15  4:20   ` Richard Henderson [this message]
2021-06-15  4:24     ` Jason Thorpe
2021-06-16 13:53       ` Jason Thorpe
2021-06-16 16:55         ` Richard Henderson
2021-06-13 21:15 ` [PATCH 4/4] alpha: Provide console information to the PALcode at start-up Jason Thorpe
2021-06-15  4:08   ` Richard Henderson
2021-06-14 22:09 ` [PATCH 0/4] Emulator fixes to enable running NetBSD/alpha no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8346c497-f432-0d75-bc60-0fcceed3420f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thorpej@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).