From: Richard Henderson <richard.henderson@linaro.org>
To: Emilio Cota <cota@braap.org>
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org,
aaron@os.amperecomputing.com,
frederic.petrot@univ-grenoble-alpes.fr
Subject: Re: [PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit
Date: Thu, 2 Mar 2023 11:16:59 -0800 [thread overview]
Message-ID: <834aba50-7b64-8acf-0d08-1cd086e3ac24@linaro.org> (raw)
In-Reply-To: <Y/8/iCIOVdAwcgW0@cota-l14>
On 3/1/23 02:05, Emilio Cota wrote:
> As I mentioned in the patch that is being superseded here
> I like this approach -- it is simpler and generates less
> code.
>
> I'd also like to see the plugin_gen_disable_mem_helpers
> function go away, and a mention somewhere that now we are
> intentionally not clearing cpu->plugin_mem_cbs until TB exit
> (before we weren't doing that either, but that was unintentional
> due to a bug). So, for instance when doing a goto_tb from a
> TB with helpers, we leave plugin_mem_cbs set.
plugin_mem_cbs is used by all out-of-line load/store, therefore we cannot leave it set
longer than required.
r~
next prev parent reply other threads:[~2023-03-02 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 2:47 [PATCH 0/2] plugin: fix clearing of plugin_mem_cbs on TB exit Richard Henderson
2023-03-01 2:47 ` [PATCH 1/2] tcg: Clear " Richard Henderson
2023-03-01 12:05 ` Emilio Cota
2023-03-02 18:47 ` Richard Henderson
2023-03-02 19:16 ` Richard Henderson [this message]
2023-03-01 2:47 ` [PATCH 2/2] include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT Richard Henderson
2023-03-03 16:57 ` [PATCH 0/2] plugin: fix clearing of plugin_mem_cbs on TB exit Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834aba50-7b64-8acf-0d08-1cd086e3ac24@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aaron@os.amperecomputing.com \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=frederic.petrot@univ-grenoble-alpes.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).