From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-block@nongnu.org, Li Qiang <liq3ea@gmail.com>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>,
Alexander Bulekov <alxndr@bu.edu>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 1/2] floppy: add a regression test for CVE-2020-25741
Date: Fri, 19 Mar 2021 11:17:47 +0100 [thread overview]
Message-ID: <8383637a-ad52-e4d7-a0ff-876898bf1905@redhat.com> (raw)
In-Reply-To: <87v99nmpsi.fsf@dusky.pond.sub.org>
On 19/03/21 10:54, Markus Armbruster wrote:
> A commit message should tell me what the patch is trying to accomplish.
>
> This commit message's title tells me it's a test for a CVE. Okay. The
> body additionally gives me the reproducer. To be useful, a reproducer
> needs to come with actual and expected result. Yes, I can find those in
> the patch. But I could find the reproducer there, too. If you're nice
> enough to save me the trouble of digging through the patch for the
> reproducer (thanks), please consider saving me the trouble digging for
> the information I need to make use of it (thanks again). That's all:)
FWIW I don't think in this case there is an expected result other than
not crashing, but yeah it may be worth adding in the commit message "for
CVE-2020-25741, a {crash,undefined behavior,ASAN violation} in func_name".
Paolo
next prev parent reply other threads:[~2021-03-19 10:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 11:38 [PATCH] fdc: check null block pointer before blk_pwrite P J P
2020-09-15 12:47 ` P J P
2020-09-18 10:52 ` Li Qiang
2021-03-19 5:09 ` [PATCH 1/2] floppy: add a regression test for CVE-2020-25741 Alexander Bulekov
2021-03-19 5:09 ` [PATCH 2/2] floppy: add a regression test for CVE-2021-20196 Alexander Bulekov
2021-03-19 5:53 ` [PATCH 1/2] floppy: add a regression test for CVE-2020-25741 Markus Armbruster
2021-03-19 9:26 ` Paolo Bonzini
2021-03-19 9:54 ` Markus Armbruster
2021-03-19 10:17 ` Paolo Bonzini [this message]
2021-03-19 14:51 ` Alexander Bulekov
2021-03-19 14:52 ` Alexander Bulekov
2021-05-18 17:30 ` [PATCH] fdc: check null block pointer before blk_pwrite John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8383637a-ad52-e4d7-a0ff-876898bf1905@redhat.com \
--to=pbonzini@redhat.com \
--cc=alxndr@bu.edu \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=liq3ea@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).