* [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation
@ 2023-08-01 15:45 Peter Maydell
2023-08-01 18:21 ` Philippe Mathieu-Daudé
2023-08-01 21:46 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2023-08-01 15:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, Philippe Mathieu-Daudé, Keith Packard
The arguments for deposit64 are (value, start, length, fieldval); this
appears to have thought they were (value, fieldval, start,
length). Reorder the parameters to match the actual function.
Cc: qemu-stable@nongnu.org
Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h")
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Same fix for m68k as Keith Packard just sent for nios2
---
target/m68k/m68k-semi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
index 88ad9ba8144..239f6e44e90 100644
--- a/target/m68k/m68k-semi.c
+++ b/target/m68k/m68k-semi.c
@@ -166,7 +166,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr)
GET_ARG64(2);
GET_ARG64(3);
semihost_sys_lseek(cs, m68k_semi_u64_cb, arg0,
- deposit64(arg2, arg1, 32, 32), arg3);
+ deposit64(arg2, 32, 32, arg1), arg3);
break;
case HOSTED_RENAME:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation
2023-08-01 15:45 [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation Peter Maydell
@ 2023-08-01 18:21 ` Philippe Mathieu-Daudé
2023-08-01 21:46 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-01 18:21 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Laurent Vivier, Keith Packard
On 1/8/23 17:45, Peter Maydell wrote:
> The arguments for deposit64 are (value, start, length, fieldval); this
> appears to have thought they were (value, fieldval, start,
> length). Reorder the parameters to match the actual function.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h")
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Same fix for m68k as Keith Packard just sent for nios2
> ---
> target/m68k/m68k-semi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
> index 88ad9ba8144..239f6e44e90 100644
> --- a/target/m68k/m68k-semi.c
> +++ b/target/m68k/m68k-semi.c
> @@ -166,7 +166,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr)
> GET_ARG64(2);
> GET_ARG64(3);
> semihost_sys_lseek(cs, m68k_semi_u64_cb, arg0,
> - deposit64(arg2, arg1, 32, 32), arg3);
> + deposit64(arg2, 32, 32, arg1), arg3);
> break;
>
> case HOSTED_RENAME:
Thanks for writing the fix!
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation
2023-08-01 15:45 [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation Peter Maydell
2023-08-01 18:21 ` Philippe Mathieu-Daudé
@ 2023-08-01 21:46 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-01 21:46 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Laurent Vivier, Keith Packard
On 1/8/23 17:45, Peter Maydell wrote:
> The arguments for deposit64 are (value, start, length, fieldval); this
> appears to have thought they were (value, fieldval, start,
> length). Reorder the parameters to match the actual function.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h")
> Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Same fix for m68k as Keith Packard just sent for nios2
> ---
> target/m68k/m68k-semi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, queued via misc-fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-01 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 15:45 [PATCH for-8.1] target/m68k: Fix semihost lseek offset computation Peter Maydell
2023-08-01 18:21 ` Philippe Mathieu-Daudé
2023-08-01 21:46 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).