Re: [Qemu-devel] [PATCH 4/7] sockets: Rename SocketAddress to SocketAddressLegacy

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

On 04/26/2017 02:36 AM, Markus Armbruster wrote:
> The next commit will rename SocketAddressFlat to SocketAddress, and
> the commit after that will replace most uses of SocketAddressLegacy by
> SocketAddress, replacing most of this commit's renames right back.
> 
> Note that checkpatch emits a few "line over 80 characters" warnings.
> The long lines are all temporary; the SocketAddressLegacy replacement
> will shorten them again.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

> @@ -530,17 +530,17 @@ static void sd_aio_setup(SheepdogAIOCB *acb, BDRVSheepdogState *s,
>      QLIST_INSERT_HEAD(&s->inflight_aiocb_head, acb, aiocb_siblings);
>  }
>  
> -static SocketAddress *sd_socket_address(const char *path,
> +static SocketAddressLegacy *sd_socket_address(const char *path,
>                                          const char *host, const char *port)

And the indentation will get fixed up later, too.


> @@ -205,12 +205,12 @@ void qio_channel_socket_dgram_async(QIOChannelSocket *ioc,
>   * Get the string representation of the local socket
>   * address. A pointer to the allocated address information
>   * struct will be returned, which the caller is required to
> - * release with a call qapi_free_SocketAddress when no
> + * release with a call qapi_free_SocketAddressLegacy() when no

I see you did slightly more than just a mechanical change. That's okay.

Mostly mechanical (since the compiler complains if you still use the old
name of the struct or enum values), but I'm glad you also corrected
comments.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]