From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Id9v4-0001oz-K8
	for qemu-devel@nongnu.org; Wed, 03 Oct 2007 15:30:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Id9v2-0001l3-Pp
	for qemu-devel@nongnu.org; Wed, 03 Oct 2007 15:30:05 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Id9v2-0001kq-IU
	for qemu-devel@nongnu.org; Wed, 03 Oct 2007 15:30:04 -0400
Received: from wa-out-1112.google.com ([209.85.146.177])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <edusaper@gmail.com>) id 1Id9v1-0007gU-4f
	for qemu-devel@nongnu.org; Wed, 03 Oct 2007 15:30:04 -0400
Received: by wa-out-1112.google.com with SMTP id k22so7925341waf
	for <qemu-devel@nongnu.org>; Wed, 03 Oct 2007 12:30:01 -0700 (PDT)
Message-ID: <83a4d4ca0710031229u68202e6aub32ba6257dfb0bc0@mail.gmail.com>
Date: Wed, 3 Oct 2007 21:29:59 +0200
From: "Eduardo Felipe" <edusaper@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_Part_23215_2640835.1191439799816"
Subject: [Qemu-devel] [Patch] VNC: Fix crash with non-resizing clients
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

------=_Part_23215_2640835.1191439799816
Content-Type: multipart/alternative;
	boundary="----=_Part_23216_17545305.1191439799816"

------=_Part_23216_17545305.1191439799816
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

2007/9/25, GUERRAZ Francois <francois.guerraz@alyotech.fr>:
>
>
> About your VNC problems : I have had problems w/ vnc too (see
> http://qemu-forum.ipi.fi/viewtopic.php?p=10468) but had no answer as
> well...


This problem happens when the VNC client doesn't support the DesktopSize
pseudo-encoding. Qemu crashes when the guest resizes down its display and
the VNC client sends a SetPixelFormat afterwards.

Attached patch should fix this. It also forces a full buffer update after
resize.

Regards,
Edu

------=_Part_23216_17545305.1191439799816
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,<br>
<br><div><span class="gmail_quote">2007/9/25, GUERRAZ Francois &lt;<a href="mailto:francois.guerraz@alyotech.fr">francois.guerraz@alyotech.fr</a>&gt;:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>About your VNC problems : I have had problems w/ vnc too (see<br><a href="http://qemu-forum.ipi.fi/viewtopic.php?p=10468">http://qemu-forum.ipi.fi/viewtopic.php?p=10468</a>) but had no answer as<br>well...</blockquote>
<div><br>This problem happens when the VNC client doesn&#39;t support the DesktopSize pseudo-encoding.  Qemu crashes when the guest resizes down its display and the VNC client sends a SetPixelFormat afterwards.<br><br>Attached patch should fix this. It also forces a full buffer update after resize.
<br><br>Regards,<br>Edu<br></div></div><br>

------=_Part_23216_17545305.1191439799816--

------=_Part_23215_2640835.1191439799816
Content-Type: text/x-patch; name="vnc-crash-on-resize.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="vnc-crash-on-resize.patch"; filename="vnc-crash-on-resize.patch";
 filename="vnc-crash-on-resize.patch"
X-Attachment-Id: f_f7c88ych

KioqIHZuYy5jCTMwIFNlcCAyMDA3IDEzOjAxOjE1IC0wMDAwCTEuMjUNCi0tLSB2bmMuYwkzIE9j
dCAyMDA3IDE4OjQ0OjE3IC0wMDAwDQpAQCAtMjg5LDE1ICsyODksMTkgQEANCiAgICAgZHMtPndp
ZHRoID0gdzsNCiAgICAgZHMtPmhlaWdodCA9IGg7DQogICAgIGRzLT5saW5lc2l6ZSA9IHcgKiB2
cy0+ZGVwdGg7DQotICAgIGlmICh2cy0+Y3NvY2sgIT0gLTEgJiYgdnMtPmhhc19yZXNpemUgJiYg
c2l6ZV9jaGFuZ2VkKSB7DQotCXZuY193cml0ZV91OCh2cywgMCk7ICAvKiBtc2cgaWQgKi8NCi0J
dm5jX3dyaXRlX3U4KHZzLCAwKTsNCi0Jdm5jX3dyaXRlX3UxNih2cywgMSk7IC8qIG51bWJlciBv
ZiByZWN0cyAqLw0KLQl2bmNfZnJhbWVidWZmZXJfdXBkYXRlKHZzLCAwLCAwLCBkcy0+d2lkdGgs
IGRzLT5oZWlnaHQsIC0yMjMpOw0KLQl2bmNfZmx1c2godnMpOw0KLQl2cy0+d2lkdGggPSBkcy0+
d2lkdGg7DQotCXZzLT5oZWlnaHQgPSBkcy0+aGVpZ2h0Ow0KKyAgICBpZiAoc2l6ZV9jaGFuZ2Vk
KSB7DQorICAgICAgICBpZiAodnMtPmNzb2NrICE9IC0xICYmIHZzLT5oYXNfcmVzaXplKSB7DQor
ICAgICAgICAgICAgdm5jX3dyaXRlX3U4KHZzLCAwKTsgIC8qIG1zZyBpZCAqLw0KKyAgICAgICAg
ICAgIHZuY193cml0ZV91OCh2cywgMCk7DQorICAgICAgICAgICAgdm5jX3dyaXRlX3UxNih2cywg
MSk7IC8qIG51bWJlciBvZiByZWN0cyAqLw0KKyAgICAgICAgICAgIHZuY19mcmFtZWJ1ZmZlcl91
cGRhdGUodnMsIDAsIDAsIGRzLT53aWR0aCwgZHMtPmhlaWdodCwgLTIyMyk7DQorICAgICAgICAg
ICAgdm5jX2ZsdXNoKHZzKTsNCisgICAgICAgIH0NCisgICAgICAgIG1lbXNldCh2cy0+ZGlydHlf
cm93LCAweEZGLCBzaXplb2YodnMtPmRpcnR5X3JvdykpOw0KKyAgICAgICAgbWVtc2V0KHZzLT5v
bGRfZGF0YSwgNDIsIGRzLT5saW5lc2l6ZSAqIGRzLT5oZWlnaHQpOw0KICAgICB9DQorICAgIHZz
LT53aWR0aCA9IGRzLT53aWR0aDsNCisgICAgdnMtPmhlaWdodCA9IGRzLT5oZWlnaHQ7DQogfQ0K
IA0KIC8qIGZhc3Rlc3QgY29kZSAqLw0KDQo=
------=_Part_23215_2640835.1191439799816--