qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Eduardo Felipe" <edusaper@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Windows compile errors
Date: Fri, 16 May 2008 12:15:46 +0200	[thread overview]
Message-ID: <83a4d4ca0805160315i49c04b7dmd056bb39659ba4d2@mail.gmail.com> (raw)
In-Reply-To: <g0j351$cjk$1@ger.gmane.org>

2008/5/16 Alex <void@aleksoft.net>:
>
> > AFAIR sleep() takes seconds, while Sleep() takes milliseconds as an
> > argument.
> >
>
> You are right. Perhaps this is a better patch:
>
> Index: slirp/slirp.h
> ===================================================================
> --- slirp/slirp.h       (revision 4462)
> +++ slirp/slirp.h       (working copy)
> @@ -28,6 +28,7 @@
>  typedef uint32_t u_int32_t;
>  typedef uint64_t u_int64_t;
>  typedef char *caddr_t;
> +typedef int socklen_t;
>
>  #define WIN32_LEAN_AND_MEAN
>  # include <windows.h>

There's no need to explicitly typedef socklen_t, it is already done in
ws2tcpip.h:

--- slirp/slirp.h	Mon May 12 19:44:40 2008
+++ slirp/slirp.h	Mon May 12 19:44:05 2008
@@ -32,6 +32,7 @@
 #define WIN32_LEAN_AND_MEAN
 # include <windows.h>
 # include <winsock2.h>
+# include <ws2tcpip.h>
 # include <sys/timeb.h>
 # include <iphlpapi.h>

Regards,
Edu

  parent reply	other threads:[~2008-05-16 10:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16  0:04 [Qemu-devel] [PATCH] Windows compile errors consul
2008-05-16  0:15 ` Johannes Schindelin
2008-05-16  4:38   ` [Qemu-devel] " Alex
2008-05-16  9:44     ` Johannes Schindelin
2008-05-16 16:00       ` [Qemu-devel] " consul
2008-05-16 16:16         ` andrzej zaborowski
2008-05-16 16:29         ` [Qemu-devel] " Jan Kiszka
2008-05-17  2:17           ` Alex
2008-05-17 12:22             ` Jan Kiszka
2008-05-16 10:15     ` Eduardo Felipe [this message]
2008-05-16  0:38 ` [Qemu-devel] " Erik de Castro Lopo
2008-05-16  4:23   ` [Qemu-devel] " Alex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83a4d4ca0805160315i49c04b7dmd056bb39659ba4d2@mail.gmail.com \
    --to=edusaper@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).