From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LT0Bj-0006dZ-TU
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:42:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LT0Bf-0006cY-IE
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:42:07 -0500
Received: from [199.232.76.173] (port=60883 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LT0Bf-0006cV-CF
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:42:03 -0500
Received: from mail-bw0-f12.google.com ([209.85.218.12]:45169)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <edusaper@gmail.com>) id 1LT0Be-0005Um-MV
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:42:03 -0500
Received: by bwz5 with SMTP id 5so261937bwz.10
	for <qemu-devel@nongnu.org>; Fri, 30 Jan 2009 12:41:58 -0800 (PST)
MIME-Version: 1.0
Date: Fri, 30 Jan 2009 21:40:38 +0100
Message-ID: <83a4d4ca0901301240s75bb2b7au77b60a4bdb136076@mail.gmail.com>
From: Eduardo Felipe <edusaper@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] [PATCH] Fix regression introduced by 6398
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

Hi,

After commit 6398 some of my guests started to SEGFAULT at boot time.
Reverting these two lines fixes the problem for me:

signed-off-by: Eduardo Felipe <edusaper@gmail.com>

--- a/hw/ide.c    Fri Jan 30 21:15:15 2009
+++ b/hw/ide.c    Fri Jan 30 21:13:49 2009
@@ -1084,7 +1084,7 @@
 #ifdef DEBUG_AIO
     printf("aio_read: sector_num=%" PRId64 " n=%d\n", sector_num, n);
 #endif
-    bm->aiocb = bdrv_aio_readv(s->bs, sector_num, &s->iovec, n,
+    bm->aiocb = bdrv_aio_read(s->bs, sector_num, s->io_buffer, n,
                                ide_read_dma_cb, bm);
     ide_dma_submit_check(s, ide_read_dma_cb, bm);
 }
@@ -1212,7 +1212,7 @@
 #ifdef DEBUG_AIO
     printf("aio_write: sector_num=%" PRId64 " n=%d\n", sector_num, n);
 #endif
-    bm->aiocb = bdrv_aio_writev(s->bs, sector_num, &s->iovec, n,
+    bm->aiocb = bdrv_aio_write(s->bs, sector_num, s->io_buffer, n,
                                 ide_write_dma_cb, bm);
     ide_dma_submit_check(s, ide_write_dma_cb, bm);
 }


Can anybody take a look at it?

Thanks,
Edu