From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Nabih Estefan" <nabihestefan@google.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, lvivier@redhat.com,
farosas@suse.de, sriram.yagnaraman@ericsson.com,
akihiko.odaki@daynix.com
Subject: Re: [PATCH v2] Running with `--enable-ubsan` leads to a qtest failure:
Date: Wed, 30 Apr 2025 14:31:49 +0200 [thread overview]
Message-ID: <83b80b4d-0ce1-4002-872e-1577527e88fa@linaro.org> (raw)
In-Reply-To: <87cyct3owr.fsf@draig.linaro.org>
Subject is missing. What about "tests/qtest/igb: Avoid misaligned access"?
On 30/4/25 12:49, Alex Bennée wrote:
> Nabih Estefan <nabihestefan@google.com> writes:
>
>> v2: used ldl_le_p and lduw_l_p instead of memcpy as per upstream
>> suggestion.
This comment is not useful in git history.
>>
>> ```
>> ../tests/qtest/libqos/igb.c:106:5: runtime error: load of misaligned address 0x562040be8e33 for type 'uint32_t', which requires 4 byte alignment
>> ```
>> Instead of straight casting the uint8_t array, we use memcpy to assure
>> alignment is correct against uint32_t and uint16_t.
>
> Queued to testing/next, thanks.
>
next prev parent reply other threads:[~2025-04-30 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 15:56 [PATCH v2] Running with `--enable-ubsan` leads to a qtest failure: Nabih Estefan
2025-04-30 2:48 ` Richard Henderson
2025-04-30 9:18 ` Laurent Vivier
2025-04-30 10:49 ` Alex Bennée
2025-04-30 12:31 ` Philippe Mathieu-Daudé [this message]
2025-04-30 12:03 ` Peter Maydell
2025-04-30 16:48 ` Nabih Estefan
2025-04-30 17:06 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83b80b4d-0ce1-4002-872e-1577527e88fa@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=alex.bennee@linaro.org \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=nabihestefan@google.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).