From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUnIi-0000b3-38 for qemu-devel@nongnu.org; Tue, 02 Aug 2016 23:57:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUnId-0007uk-3n for qemu-devel@nongnu.org; Tue, 02 Aug 2016 23:56:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:34447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUnIc-0007tn-TG for qemu-devel@nongnu.org; Tue, 02 Aug 2016 23:56:55 -0400 References: <1470119552-16170-1-git-send-email-jgross@suse.com> From: Juergen Gross Message-ID: <83be5a6c-84b3-652c-84e7-68de3813dc6a@suse.com> Date: Wed, 3 Aug 2016 05:56:45 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] xen: use a common function for pv and hvm guest backend register calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com, kraxel@redhat.com, anthony.perard@citrix.com On 02/08/16 20:27, Stefano Stabellini wrote: > On Tue, 2 Aug 2016, Juergen Gross wrote: >> Instead of calling xen_be_register() for each supported backend type >> for hvm and pv guests in their machine init functions use a common >> function in order not to have to add new backends twice. >> >> This at once fixes the error that hvm domains couldn't use the qusb >> backend. >> >> Signed-off-by: Juergen Gross >> --- >> Is it on purpose the qnic and vfb backends are not registered for HVM? > > Yes, it is on purpose: there is no code in any toolstacks to use qnic, > and the presence of vfb can cause problems to Linux HVM guests (or at > least it used to), additionally vfb for HVM guests is also disabled in > libxl. > > In general, it is a good idea to disable code that is not supposed to be > used. > > Can qusb be used with HVM guests with libxl/xl? Yes. You have to specify "type=qusb" for usbctrl, then it will work. I have verified that. Juergen