From: John Snow <jsnow@redhat.com>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, hpoussin@reactos.org,
Aleksandar Markovic <amarkovic@wavecomp.com>,
Paolo Bonzini <pbonzini@redhat.com>,
philmd@redhat.com, Artyom Tarasenko <atar4qemu@gmail.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 0/8] Misc hw/ide legacy clean up
Date: Tue, 17 Mar 2020 15:09:59 -0400 [thread overview]
Message-ID: <83d9a8f7-865f-a584-d2fa-8cf48cd4700b@redhat.com> (raw)
In-Reply-To: <alpine.BSF.2.22.395.2003171931520.35246@zero.eik.bme.hu>
On 3/17/20 2:34 PM, BALATON Zoltan wrote:
> On Tue, 17 Mar 2020, John Snow wrote:
>> On 3/17/20 11:05 AM, BALATON Zoltan wrote:
>>> Avoid problems from reassigning variable in piix4_create and fix
>>> compilation problem with mips_r4k
>>>
>>> BALATON Zoltan (8):
>>> hw/ide: Get rid of piix3_init functions
>>> hw/isa/piix4.c: Introduce variable to store devfn
>>> hw/ide: Get rid of piix4_init function
>>> hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h
>>> hw/ide/pci.c: Coding style update to fix checkpatch errors
>>> hw/ide: Do ide_drive_get() within pci_ide_create_devs()
>>> hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h
>>> hw/ide: Remove unneeded inclusion of hw/ide.h
>>>
>>> hw/alpha/dp264.c | 13 +++----------
>>> hw/hppa/hppa_sys.h | 1 -
>>> hw/hppa/machine.c | 1 -
>>> hw/i386/pc_piix.c | 18 +++++++++---------
>>> hw/ide/ahci_internal.h | 1 +
>>> hw/ide/pci.c | 11 +++++++----
>>> hw/ide/piix.c | 31 +------------------------------
>>> hw/isa/piix4.c | 23 ++++++++++-------------
>>> hw/mips/mips_fulong2e.c | 5 +----
>>> hw/mips/mips_malta.c | 2 +-
>>> hw/mips/mips_r4k.c | 1 +
>>> hw/ppc/mac_newworld.c | 1 -
>>> hw/ppc/mac_oldworld.c | 1 -
>>> hw/ppc/prep.c | 1 -
>>> hw/sparc64/sun4u.c | 6 +-----
>>> include/hw/ide.h | 6 ------
>>> include/hw/ide/internal.h | 2 ++
>>> include/hw/ide/pci.h | 3 ++-
>>> include/hw/misc/macio/macio.h | 1 +
>>> include/hw/southbridge/piix.h | 3 +--
>>> 20 files changed, 41 insertions(+), 90 deletions(-)
>>>
>>
>> Passed local testing. Pushed to gitlab and pending further tests.
>>
>> Track here: https://gitlab.com/jsnow/qemu/pipelines/127143307
>
> These tests don't seem to compile mips64el-softmmu target so probably
> miss some of these which are only used on those boards. (E.g. I could
> not find hw/ide/via.c mentioned in any of the logs.)
>
> Regards,
> BALATON Zoltan
>
Nope, probably not! I ran what I could locally, but anything further I
am going to be relying on your testing during RC.
--js
next prev parent reply other threads:[~2020-03-17 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 15:05 [PATCH v3 0/8] Misc hw/ide legacy clean up BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 7/8] hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 4/8] hw/ide: Remove now unneded #include "hw/pci/pci.h" from hw/ide.h BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs() BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 8/8] hw/ide: Remove unneeded inclusion of hw/ide.h BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 1/8] hw/ide: Get rid of piix3_init functions BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 3/8] hw/ide: Get rid of piix4_init function BALATON Zoltan
2020-03-17 15:05 ` [PATCH v3 2/8] hw/isa/piix4.c: Introduce variable to store devfn BALATON Zoltan
2020-03-17 15:23 ` Philippe Mathieu-Daudé
2020-03-17 15:05 ` [PATCH v3 5/8] hw/ide/pci.c: Coding style update to fix checkpatch errors BALATON Zoltan
2020-03-17 17:53 ` [PATCH v3 0/8] Misc hw/ide legacy clean up John Snow
2020-03-17 18:34 ` BALATON Zoltan
2020-03-17 19:09 ` John Snow [this message]
2020-03-17 23:21 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d9a8f7-865f-a584-d2fa-8cf48cd4700b@redhat.com \
--to=jsnow@redhat.com \
--cc=amarkovic@wavecomp.com \
--cc=armbru@redhat.com \
--cc=atar4qemu@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).