From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: eblake@redhat.com, vsementsov@yandex-team.ru
Subject: Re: [PATCH 03/10] error: Move ERRP_GUARD() to the beginning of the function
Date: Mon, 21 Nov 2022 12:19:52 +0100 [thread overview]
Message-ID: <83db8fcf-80c6-01d8-025e-b3ef85dd4d69@linaro.org> (raw)
In-Reply-To: <20221121085054.683122-4-armbru@redhat.com>
On 21/11/22 09:50, Markus Armbruster wrote:
> include/qapi/error.h advises to put ERRP_GUARD() right at the
> beginning of the function, because only then can it guard the whole
> function. Clean up the few spots disregarding the advice.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/arm/armsse.c | 3 +--
> hw/core/machine.c | 3 +--
> hw/virtio/vhost-vdpa.c | 2 +-
> iothread.c | 2 +-
> monitor/qmp-cmds.c | 4 ++--
> 5 files changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2022-11-21 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 8:50 [PATCH 00/10] Cleanups around error_propagate() and ERRP_GUARD() Markus Armbruster
2022-11-21 8:50 ` [PATCH 01/10] error: Drop some obviously superfluous error_propagate() Markus Armbruster
2022-11-21 11:14 ` Philippe Mathieu-Daudé
2022-11-21 8:50 ` [PATCH 02/10] error: Drop a few superfluous ERRP_GUARD() Markus Armbruster
2022-11-21 8:50 ` [PATCH 03/10] error: Move ERRP_GUARD() to the beginning of the function Markus Armbruster
2022-11-21 11:19 ` Philippe Mathieu-Daudé [this message]
2022-11-21 8:50 ` [PATCH 04/10] monitor: Simplify monitor_fd_param()'s error handling Markus Armbruster
2022-11-21 8:50 ` [PATCH 05/10] monitor: Use ERRP_GUARD() in monitor_init() Markus Armbruster
2022-11-21 8:50 ` [PATCH 06/10] qemu-config: Make config_parse_qdict() return bool Markus Armbruster
2022-11-21 8:50 ` [PATCH 07/10] qemu-config: Use ERRP_GUARD() where obviously appropriate Markus Armbruster
2022-11-21 8:50 ` [PATCH 08/10] sockets: " Markus Armbruster
2022-11-21 8:50 ` [PATCH 09/10] qapi: Use returned bool to check for failure (again) Markus Armbruster
2022-11-21 11:19 ` Philippe Mathieu-Daudé
2022-11-21 8:50 ` [PATCH 10/10] io: Tidy up fat-fingered parameter name Markus Armbruster
2022-11-21 11:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83db8fcf-80c6-01d8-025e-b3ef85dd4d69@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).