From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B3F5C6FD1F for ; Wed, 22 Mar 2023 11:14:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pewPk-0005PS-9w; Wed, 22 Mar 2023 07:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pewPf-0005P5-E1 for qemu-devel@nongnu.org; Wed, 22 Mar 2023 07:13:51 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pewPc-00018F-T1 for qemu-devel@nongnu.org; Wed, 22 Mar 2023 07:13:51 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MBDDEx017092; Wed, 22 Mar 2023 11:13:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=FCzYmEUU1avxchOyTLJ3xlWt3SaOhnTOtYAk6EOnFis=; b=SB1f3kO067OQH9G14mY/6gYoieGN7c0+SsrihKX838lW1V1QF4pIPJqN4huaK1gmqREc qNfXbCHL/JMU4dRTGXgAbT0Aqd977Lf12XsPhfCZrFlV0Ao9RTPyTpeJTeL+NuouMpBe wIeiqRHQOlb6RtiVMVNR63k9xyOwztuSKbg+sWl7J41gnQVEbpV6I5SlTBstX9PGl7XA tymFH2IXBycvSKt9WjwbvzoCtjIBZXXGeSD6QGuynYwEtwnILooj6rs6iLRutgWhcFwL qgEvpk4ANaJ1wCpsFt7T0vRSRxJts/9CZ/sKkqp0aqdidv27xKzkNr6Ye89L7fneFi4n iQ== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pfvetpk98-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 11:13:29 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32M8E7Zd018405; Wed, 22 Mar 2023 11:13:28 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([9.208.129.113]) by ppma01dal.us.ibm.com (PPS) with ESMTPS id 3pd4x7nuvb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 11:13:28 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32MBDQgT9044660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Mar 2023 11:13:26 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6FDB85805D; Wed, 22 Mar 2023 11:13:26 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 33A7C58043; Wed, 22 Mar 2023 11:13:26 +0000 (GMT) Received: from [9.211.67.180] (unknown [9.211.67.180]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Mar 2023 11:13:26 +0000 (GMT) Message-ID: <83e104a6-9165-3bfb-387d-f5cc1c053261@linux.vnet.ibm.com> Date: Wed, 22 Mar 2023 06:13:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/3] Add support for TPM devices over I2C bus Content-Language: en-US To: Stefan Berger , Ninad Palsule , qemu-devel@nongnu.org Cc: joel@jms.id.au, andrew@aj.id.au, clg@kaod.org References: <20230321053001.3886666-1-ninad@linux.ibm.com> <20230321053001.3886666-2-ninad@linux.ibm.com> From: Ninad Palsule In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: wC1G5GL9ZhJjLblzTh65sWMfmdjzAwXQ X-Proofpoint-GUID: wC1G5GL9ZhJjLblzTh65sWMfmdjzAwXQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_08,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 mlxlogscore=999 clxscore=1011 suspectscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220072 Received-SPF: none client-ip=148.163.156.1; envelope-from=ninad@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/21/23 6:35 PM, Stefan Berger wrote: > > > On 3/21/23 01:29, Ninad Palsule wrote: >> This is a documentation change for I2C TPM device support. >> >> Qemu already supports devices attached to ISA and sysbus. >> This drop adds support for the I2C bus attached TPM devices. >> >> Signed-off-by: Ninad Palsule >> --- >>   docs/specs/tpm.rst | 5 ++++- >>   1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/docs/specs/tpm.rst b/docs/specs/tpm.rst >> index 535912a92b..79a79f0640 100644 >> --- a/docs/specs/tpm.rst >> +++ b/docs/specs/tpm.rst >> @@ -21,11 +21,14 @@ QEMU files related to TPM TIS interface: >>    - ``hw/tpm/tpm_tis_common.c`` >>    - ``hw/tpm/tpm_tis_isa.c`` >>    - ``hw/tpm/tpm_tis_sysbus.c`` >> + - ``hw/tpm/tpm_tis_i2c.c`` >>    - ``hw/tpm/tpm_tis.h`` >>     Both an ISA device and a sysbus device are available. The former is >>   used with pc/q35 machine while the latter can be instantiated in the >> -Arm virt machine. >> +Arm virt machine. An I2C device support is also added which can be >> +instantiated in the arm based emulation machine. I2C model only >> supports >> +TPM2 protocol. > > > An I2C device is also supported for the Arm virt machine. This device > only supports the TPM 2 protocol. > >    Stefan > Updated the document. Thank you for the review! Ninad Palsule >>     CRB interface >>   -------------